[Textfield] Consider select all status for select all context menu

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 87 matching lines @@
 
   // Returns the text that is currently selected. Call sites should take care to
   // not reveal the text for a password textfield.
   base::string16 GetSelectedText() const;
 
   // Select the entire text range. If |reversed| is true, the range will end at
   // the logical beginning of the text; this generally shows the leading portion
   // of text that overflows its display area.
   void SelectAll(bool reversed);
 
+  // Return false when text is empty.

[Peter Kasting, 2017/04/20 00:08:30]

Nit: "Returns whether all the text is currently selected.  Returns false if
there is no text."

[simonhong, 2017/04/20 13:11:51]

Removed.

+  bool IsAllSelected() const;

[Peter Kasting, 2017/04/20 00:08:30]

Nit: Does this need to be public?  If we're only using it internally, why not
make it private?  If it's only being called in one place, why not just inline
the implementation there?  Or are you planning on using this in other places?

[simonhong, 2017/04/20 13:11:51]

Making it public is mistake.
At first, I added as a method for test purpose.
However, I convinced that we can test without this method.
Inlined.

+
   // A convenience method to select the word closest to |point|.
   void SelectWordAt(const gfx::Point& point);
 
   // Clears the selection within the edit field and sets the caret to the end.
   void ClearSelection();
 
   // Checks if there is any selected text.
   bool HasSelection() const;
 
   // Gets/sets the text color to be used when painting the Textfield.
@@ skipping 414 matching lines @@
 
   // Used to bind callback functions to this object.
   base::WeakPtrFactory<Textfield> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_