Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2829793002: Disable logging in CryptAuthBluetoothLowEnergyWeaveClientConnectionTest. It was too spammy. (Closed)

Created:
3 years, 8 months ago by Kyle Horimoto
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable logging in CryptAuthBluetoothLowEnergyWeaveClientConnectionTest. It was too spammy. BUG=711741 Review-Url: https://codereview.chromium.org/2829793002 Cr-Commit-Position: refs/heads/master@{#465803} Committed: https://chromium.googlesource.com/chromium/src/+/b55e4c29cbe6a07d9e75a386933342cbd80e5cd9

Patch Set 1 #

Patch Set 2 : Add missing DEP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/cryptauth/ble/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Kyle Horimoto
3 years, 8 months ago (2017-04-19 19:31:15 UTC) #2
Nico
rs-lgtm
3 years, 8 months ago (2017-04-19 19:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829793002/1
3 years, 8 months ago (2017-04-19 19:50:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/353284) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 8 months ago (2017-04-19 19:54:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829793002/20001
3 years, 8 months ago (2017-04-19 21:55:25 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 23:06:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b55e4c29cbe6a07d9e75a3869333...

Powered by Google App Engine
This is Rietveld 408576698