bluetooth-internals: Fix flaky test

chrome/test/data/webui/bluetooth_internals_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Tests for chrome://bluetooth-internals
  */
 
 /** @const {string} Path to source root. */
 var ROOT_PATH = '../../../../';
@@ skipping 289 matching lines @@
     return {
       id: 'characteristic1',
       uuid: '00002a19-0000-1000-8000-00805f9b34fb',
       properties: Number.MAX_SAFE_INTEGER,
       permissions: Number.MAX_SAFE_INTEGER,
       last_known_value: [],
     };
   },
 };
 
-// Flaky on Debug and ASAN. See crbug.com/707530
-GEN('#if !defined(NDEBUG) || defined(ADDRESS_SANITIZER)');
-GEN('#define MAYBE_Startup_BluetoothInternals ' +
-    'DISABLED_Startup_BluetoothInternals');
-GEN('#else');
-GEN('#define MAYBE_Startup_BluetoothInternals Startup_BluetoothInternals');
-GEN('#endif');
-
-TEST_F('BluetoothInternalsTest', 'MAYBE_Startup_BluetoothInternals',
+TEST_F('BluetoothInternalsTest', 'Startup_BluetoothInternals',

[dpapad, 2017/04/20 01:38:06]

FWIW, I am planning to disable all WebUI tests in *SAN bots. I landed this a
while ago, but got reverted, https://codereview.chromium.org/2690303003. Will
get back to it soon.

I am suspecting that even with this fix the test might still fail (meaning
timeout) on such bots.

     function() {
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
 
   var adapterFactory = null;
   var adapterFieldSet = null;
   var deviceTable = null;
   var sidebarNode = null;
   var pageNames = ['adapter', 'devices'];
 
   var fakeAdapterInfo = this.fakeAdapterInfo;
@@ skipping 341 matching lines @@
 
       function next() {
         assertTrue(false);
       }
 
       whenSnackbarShows(snackbar2).then(next);
       snackbar2.addEventListener('dismissed', next);
       whenSnackbarShows(snackbar3).then(next);
       snackbar3.addEventListener('dismissed', next);
 
-      whenSnackbarShows(snackbar1).then(function() {
+      return whenSnackbarShows(snackbar1).then(function() {
         return snackbar.Snackbar.dismiss(true);
       }).then(function() {
         expectEquals(0, snackbar.Snackbar.queue_.length);
         expectFalse(!!snackbar.Snackbar.current_);
       }).then(finishSnackbarTest);
     });
 
     /* AdapterPage Tests */
     function checkAdapterFieldSet(adapterInfo) {
       for (var propName in adapterInfo) {
@@ skipping 251 matching lines @@
     test('ValueControl_ConvertValue_Decimal_ThreeValues', function() {
       valueControl.typeSelect_.value = ValueDataType.DECIMAL
       valueControl.value_.setAs(ValueDataType.DECIMAL, '97-98-99' /* abc */);
       expectDeepEquals([aCode, bCode, cCode], valueControl.value_.getArray());
     });
   });
 
   // Run all registered tests.
   mocha.run();
 });