Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2829763002: [Ash] Remove HoverHighlightView::AddLabelDeprecated() (Closed)

Created:
3 years, 8 months ago by tdanderson
Modified:
3 years, 8 months ago
Reviewers:
mohsen
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ash] Remove HoverHighlightView::AddLabelDeprecated() Removes the function AddLabelDeprecated() in HoverHighlightView and replaces its only call site with a new function TrayPopupUtils::CreateInfoLabelRowView(), which creates a MD-compliant non-clickable row used to display the "Scanning for devices..." message in the Bluetooth detailed view. This CL also removes the unnecessary member variables |tooltip_| and |custom_height_| from HoverHighlightView, along with corresponding dead code. BUG=708190, 687778 TEST=manual Review-Url: https://codereview.chromium.org/2829763002 Cr-Commit-Position: refs/heads/master@{#466013} Committed: https://chromium.googlesource.com/chromium/src/+/0dfa9b6dfb54257572995b17dd2f81ea07454d1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -105 lines) Patch
M ash/system/bluetooth/tray_bluetooth.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M ash/system/network/network_state_list_detailed_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/palette/common_palette_tool.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/system/tray/hover_highlight_view.h View 6 chunks +0 lines, -24 lines 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 5 chunks +1 line, -59 lines 0 comments Download
M ash/system/tray/tray_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_popup_item_style.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/system/tray/tray_popup_utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/system/tray/tray_popup_utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tdanderson
Mohsen, can you please take a look?
3 years, 8 months ago (2017-04-19 19:04:08 UTC) #3
mohsen
lgtm
3 years, 8 months ago (2017-04-20 06:03:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829763002/1
3 years, 8 months ago (2017-04-20 15:10:58 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:18:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0dfa9b6dfb54257572995b17dd2f...

Powered by Google App Engine
This is Rietveld 408576698