Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2829753004: [ObjC ARC] Converts ios/chrome/browser/ui/webui:webui_internal to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/webui:webui_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2829753004 Cr-Commit-Position: refs/heads/master@{#466278} Committed: https://chromium.googlesource.com/chromium/src/+/bffdac48c4e7381755e0a09ef5f431e80c432b1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/webui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-20 08:00:20 UTC) #4
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-20 15:46:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829753004/1
3 years, 8 months ago (2017-04-21 07:01:58 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 07:06:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bffdac48c4e7381755e0a09ef5f4...

Powered by Google App Engine
This is Rietveld 408576698