Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(121)

Issue 2829723006: [DMC #1.912] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInternal() (Closed)

Created:
1 year, 1 month ago by rlanday
Modified:
1 year, 1 month ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInternal() yosin pointed out that it's confusing to have so many methods named RemoveMarkers(): https://codereview.chromium.org/2820633002#msg30 This is the second of several renaming CLs I'm going to upload BUG=707867 Review-Url: https://codereview.chromium.org/2829723006 Cr-Commit-Position: refs/heads/master@{#466309} Committed: https://chromium.googlesource.com/chromium/src/+/c0f93a9a83297a1046670164881e6bd0ce2b66d6

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove default param value #

Patch Set 3 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (13 generated)
rlanday
1 year, 1 month ago (2017-04-21 03:33:51 UTC) #3
rlanday
https://codereview.chromium.org/2829723006/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h (right): https://codereview.chromium.org/2829723006/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h#newcode133 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:133: void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes); We already have another private RemoveMarkers() ...
1 year, 1 month ago (2017-04-21 03:51:14 UTC) #5
Xiaocheng
lgtm https://codereview.chromium.org/2829723006/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h (right): https://codereview.chromium.org/2829723006/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h#newcode133 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:133: void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes); On 2017/04/21 at 03:51:13, rlanday ...
1 year, 1 month ago (2017-04-21 05:22:46 UTC) #8
rlanday
https://codereview.chromium.org/2829723006/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h (right): https://codereview.chromium.org/2829723006/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h#newcode133 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:133: void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes); On 2017/04/21 at 05:22:46, Xiaocheng wrote: ...
1 year, 1 month ago (2017-04-21 05:28:16 UTC) #11
yosin_UTC9
lgtm
1 year, 1 month ago (2017-04-21 08:19:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829723006/40001
1 year, 1 month ago (2017-04-21 08:24:03 UTC) #17
commit-bot: I haz the power
1 year, 1 month ago (2017-04-21 10:58:33 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c0f93a9a83297a1046670164881e...

Powered by Google App Engine
This is Rietveld 408576698