Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2829713003: PPC: Allow share inputs in ShiftLeftPair and ShiftRightPair (Closed)

Created:
3 years, 8 months ago by Sampson
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Allow share input in ShiftLeftPair and ShiftRightPair BUG= R=jyan@ca.ibm.com, bjaideep@ca.ibm.com, joransiu@ca.ibm.com Review-Url: https://codereview.chromium.org/2829713003 Cr-Commit-Position: refs/heads/master@{#44759} Committed: https://chromium.googlesource.com/v8/v8/+/5204f0871d609bad616ced0163ce5070a4b6cc1f

Patch Set 1 #

Patch Set 2 : Add additional check and apply the same change for ShiftRightPair #

Patch Set 3 : Change commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ppc/macro-assembler-ppc.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
john.yan
lgtm
3 years, 8 months ago (2017-04-20 19:39:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829713003/20001
3 years, 8 months ago (2017-04-20 19:42:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829713003/40001
3 years, 8 months ago (2017-04-20 21:13:36 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 21:32:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5204f0871d609bad616ced0163ce5070a4b...

Powered by Google App Engine
This is Rietveld 408576698