Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2829693003:
Fix stale display work_area on windows (Closed)
DescriptionFix stale display work_area on windows
Display screen work_area was not being updated when the location of the taskbar
changed. The notification comes as WM_SETTINGCHANGE with SPI_SETWORKAREA, which
failed to trigger a reset of the stored values without this change.
BUG=712871
Review-Url: https://codereview.chromium.org/2829693003
Cr-Commit-Position: refs/heads/master@{#473055}
Committed: https://chromium.googlesource.com/chromium/src/+/1aa2783638e90007c9e1b0a67beafc2080780faa
Patch Set 1 #Patch Set 2 : Fix stale display work_area on windows #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix stale display work_area on windows Display screen work_area was not being updated when the location of the taskbar changed. The notification comes as WM_SETTINGCHANGE with SPI_SETWORKAREA, which failed to trigger a reset of the stored values without this change. BUG=712871 ========== to ========== Fix stale display work_area on windows Display screen work_area was not being updated when the location of the taskbar changed. The notification comes as WM_SETTINGCHANGE with SPI_SETWORKAREA, which failed to trigger a reset of the stored values without this change. BUG=712871 ==========
steve@zanderz.com changed reviewers: + robliao@chromium.org
On 2017/04/20 19:16:05, zanderz wrote: > mailto:steve@zanderz.com changed reviewers: > + mailto:robliao@chromium.org Is this change ready for review (no publishing email was sent)? In either case, separate the AUTHORS change from this file change.
The CQ bit was checked by steve@zanderz.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Sorry, yes, I meant this was ready for review. Removed the AUTHORS change and moved it to https://codereview.chromium.org/2862733002/ The instructions said to add my name there. Thank you.
https://codereview.chromium.org/2862733002/ has been merged (adding me to AUTHORS).
On 2017/05/10 14:48:00, zanderz wrote: > https://codereview.chromium.org/2862733002/ has been merged (adding me to > AUTHORS). Sorry for the delay. At a conference through the end of the week, but I'll see if I can get to your change in the downtime. At face value, the change looks good; I just need to verify a few things.
lgtm. Thanks for the patch and sorry for the delay!
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
The CQ bit was unchecked by steve@zanderz.com
The CQ bit was checked by steve@zanderz.com
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495147802901940,
"parent_rev": "c6f657f00388ac1f8bb097b00e6674355b420868", "commit_rev":
"1aa2783638e90007c9e1b0a67beafc2080780faa"}
Message was sent while issue was closed.
Description was changed from ========== Fix stale display work_area on windows Display screen work_area was not being updated when the location of the taskbar changed. The notification comes as WM_SETTINGCHANGE with SPI_SETWORKAREA, which failed to trigger a reset of the stored values without this change. BUG=712871 ========== to ========== Fix stale display work_area on windows Display screen work_area was not being updated when the location of the taskbar changed. The notification comes as WM_SETTINGCHANGE with SPI_SETWORKAREA, which failed to trigger a reset of the stored values without this change. BUG=712871 Review-Url: https://codereview.chromium.org/2829693003 Cr-Commit-Position: refs/heads/master@{#473055} Committed: https://chromium.googlesource.com/chromium/src/+/1aa2783638e90007c9e1b0a67bea... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1aa2783638e90007c9e1b0a67bea... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
