DevTools: Don't lose focus when interacting with ListWidget

DevTools: Don't lose focus when interacting with ListWidget

ListWidget often removes or hides the currently focused element, causing
focus to be lost.

BUG=712540
Review-Url: https://codereview.chromium.org/2829683003
Cr-Commit-Position: refs/heads/master@{#466520}
Committed: https://chromium.googlesource.com/chromium/src/+/45a2288ee7981e473f3b9848aae3d11bb7cfab2c

[einbinder, 2017-04-19 17:02:08]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-04-19 17:02:09]

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js (right):

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:30:
this._previousFocusedElement = null;
Can't use focus restorer, because we don't necessarily want to focus the list.

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:151:
this.element.focus();
When a remove button is clicked, I don't have a good place to put focus so I am
just putting it on the widget itself.

[dgozman, 2017-04-19 19:59:34]

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js (right):

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:30:
this._previousFocusedElement = null;
On 2017/04/19 17:02:09, einbinder wrote:
> Can't use focus restorer, because we don't necessarily want to focus the list.

Could you please describe in more details?

[einbinder, 2017-04-20 16:35:27]

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js (right):

https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:30:
this._previousFocusedElement = null;
On 2017/04/19 at 19:59:34, dgozman wrote:
> On 2017/04/19 17:02:09, einbinder wrote:
> > Can't use focus restorer, because we don't necessarily want to focus the
list.
> 
> Could you please describe in more details?

The list doesn't need to steal focus, it is up to sub classes to decide if and
how they are focusable. If there was an "add item" button that created a list,
focus should stay on the button if the list item isn't editable.

Another issue with FocusRestorer is that it checks and restores at the same
time. Often the previous focused element is hidden until the the list is
removed, so the "hadFocus" variable is needed.

[einbinder, 2017-04-21 23:10:06]

Using focus restorer

[dgozman, 2017-04-21 23:38:58]

lgtm

[einbinder, 2017-04-21 23:50:13]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:50:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 01:38:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492818613117860,
"parent_rev": "1a5de509094aed3724a71314771f70a01a0584f8", "commit_rev":
"45a2288ee7981e473f3b9848aae3d11bb7cfab2c"}

[commit-bot: I haz the power, 2017-04-22 01:38:40]

Description was changed from

==========
DevTools: Don't lose focus when interacting with ListWidget

ListWidget often removes or hides the currently focused element, causing
focus to be lost.

BUG=712540
==========

to

==========
DevTools: Don't lose focus when interacting with ListWidget

ListWidget often removes or hides the currently focused element, causing
focus to be lost.

BUG=712540

Review-Url: https://codereview.chromium.org/2829683003
Cr-Commit-Position: refs/heads/master@{#466520}
Committed:
https://chromium.googlesource.com/chromium/src/+/45a2288ee7981e473f3b9848aae3...
==========

[commit-bot: I haz the power, 2017-04-22 01:38:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/45a2288ee7981e473f3b9848aae3...