Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2279)

Issue 2829683003: DevTools: Don't lose focus when interacting with ListWidget (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
dgozman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't lose focus when interacting with ListWidget ListWidget often removes or hides the currently focused element, causing focus to be lost. BUG=712540 Review-Url: https://codereview.chromium.org/2829683003 Cr-Commit-Position: refs/heads/master@{#466520} Committed: https://chromium.googlesource.com/chromium/src/+/45a2288ee7981e473f3b9848aae3d11bb7cfab2c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Focus restorer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js View 1 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
einbinder
https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js File third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js (right): https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js#newcode30 third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:30: this._previousFocusedElement = null; Can't use focus restorer, because we ...
3 years, 8 months ago (2017-04-19 17:02:09 UTC) #2
dgozman
https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js File third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js (right): https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js#newcode30 third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:30: this._previousFocusedElement = null; On 2017/04/19 17:02:09, einbinder wrote: > ...
3 years, 8 months ago (2017-04-19 19:59:34 UTC) #3
einbinder
https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js File third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js (right): https://codereview.chromium.org/2829683003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js#newcode30 third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js:30: this._previousFocusedElement = null; On 2017/04/19 at 19:59:34, dgozman wrote: ...
3 years, 8 months ago (2017-04-20 16:35:27 UTC) #4
einbinder
Using focus restorer
3 years, 8 months ago (2017-04-21 23:10:06 UTC) #5
dgozman
lgtm
3 years, 8 months ago (2017-04-21 23:38:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683003/20001
3 years, 8 months ago (2017-04-21 23:50:51 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 01:38:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/45a2288ee7981e473f3b9848aae3...

Powered by Google App Engine
This is Rietveld 408576698