Adding a Client Runtime Delegate for iOS

In order to integrating with the CRD session, we need a delegate to give to the runtime session to be able to ask for the native code to do special actions. This is needed to update how we track the chromoting session in doing real integrations.

BUG=671692
Review-Url: https://codereview.chromium.org/2829673003
Cr-Commit-Position: refs/heads/master@{#466419}
Committed: https://chromium.googlesource.com/chromium/src/+/acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81

[nicholss, 2017-04-21 17:05:00]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-04-21 17:10:50]

nicholss@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[nicholss, 2017-04-21 17:10:50]

PTAL, part of the work to get the app kicking with life.

[Lambros, 2017-04-21 18:17:04]

LGTM

The CL description seems a little vague. The only substantive thing in this CL
is adding the IosClientRuntimeDelegate class, so I would just write that in the
desc :)

https://codereview.chromium.org/2829673003/diff/40001/remoting/client/ios/fac...
File remoting/client/ios/facade/ios_client_runtime_delegate.mm (right):

https://codereview.chromium.org/2829673003/diff/40001/remoting/client/ios/fac...
remoting/client/ios/facade/ios_client_runtime_delegate.mm:23: runtime_ =
ChromotingClientRuntime::GetInstance();
Move to initialization-list?

[nicholss, 2017-04-21 18:44:32]

Description was changed from

==========
Integrating with the CRD session.

Needed to update how we track the chromoting session in doing real integrations.

BUG=671692
==========

to

==========
In order to integrating with the CRD session, we need a delegate to give to the
runtime session to be able to ask for the native code to do special actions.
This is needed to update how we track the chromoting session in doing real
integrations.

BUG=671692
==========

[nicholss, 2017-04-21 18:45:28]

I made a note about the init of runtime. I do not want to change that here
because it is used more than one place so far. Will do later.

Updated the description. Thanks for looking!

https://codereview.chromium.org/2829673003/diff/40001/remoting/client/ios/fac...
File remoting/client/ios/facade/ios_client_runtime_delegate.mm (right):

https://codereview.chromium.org/2829673003/diff/40001/remoting/client/ios/fac...
remoting/client/ios/facade/ios_client_runtime_delegate.mm:23: runtime_ =
ChromotingClientRuntime::GetInstance();
On 2017/04/21 18:17:04, Lambros wrote:
> Move to initialization-list?

I do it like this everywhere at the moment. If this is really better I would
want to update all places. I will make a note.

[nicholss, 2017-04-21 18:46:02]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2017-04-21 18:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 19:51:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492800362347250,
"parent_rev": "8b8737dc6295c7e90103617639071c71a2d621b4", "commit_rev":
"acd6c6fdc72c6ec3810094c7b0d19892ee8a4d81"}

[commit-bot: I haz the power, 2017-04-21 19:51:39]

Description was changed from

==========
In order to integrating with the CRD session, we need a delegate to give to the
runtime session to be able to ask for the native code to do special actions.
This is needed to update how we track the chromoting session in doing real
integrations.

BUG=671692
==========

to

==========
In order to integrating with the CRD session, we need a delegate to give to the
runtime session to be able to ask for the native code to do special actions.
This is needed to update how we track the chromoting session in doing real
integrations.

BUG=671692

Review-Url: https://codereview.chromium.org/2829673003
Cr-Commit-Position: refs/heads/master@{#466419}
Committed:
https://chromium.googlesource.com/chromium/src/+/acd6c6fdc72c6ec3810094c7b0d1...
==========

[commit-bot: I haz the power, 2017-04-21 19:51:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/acd6c6fdc72c6ec3810094c7b0d1...