Removed (spurious, touch-initiated) tooltips from nav buttons

Removed (spurious, touch-initiated) tooltips from nav buttons

Windows generates WM_MOUSEMOVE buttons at random points (to make sure
that apps know where the cursor is). In some cases the cursor location
was caused by a touch event - the mouse cursor jumps to the last touch
location.

This patch tracks the last touch location so that tooltips can ignore
those extraneous mousemove's.

BUG=698435
Review-Url: https://codereview.chromium.org/2829653002
Cr-Commit-Position: refs/heads/master@{#466046}
Committed: https://chromium.googlesource.com/chromium/src/+/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2

[girard, 2017-04-19 14:23:19]

girard@chromium.org changed reviewers:
+ ananta@chromium.org

[girard, 2017-04-19 14:23:19]

Ananta PTAL.

[girard, 2017-04-19 14:24:52]

Description was changed from

==========
Removed (spurious, touch-initiated) tooltips from nav buttons

Windows generates WM_MOUSEMOVE buttons at random points (to make sure
that apps know where the cursor is). In some cases the cursor location
was caused by a touch event - the mouse cursor jumps to the last touch
location.

BUG=698435
==========

to

==========
Removed (spurious, touch-initiated) tooltips from nav buttons

Windows generates WM_MOUSEMOVE buttons at random points (to make sure
that apps know where the cursor is). In some cases the cursor location
was caused by a touch event - the mouse cursor jumps to the last touch
location.

This patch tracks the last touch location so that tooltips can ignore
those extraneous mousemove's.

BUG=698435
==========

[ananta, 2017-04-19 17:57:27]

lgtm

[girard, 2017-04-19 18:18:59]

girard@chromium.org changed reviewers:
+ sadrul@chromium.org

[girard, 2017-04-19 18:19:00]

Thanks, Ananta - on to Sadrul

sadrul@chromium.org: PTAL

[sadrul, 2017-04-19 18:31:16]

Is it possible to write a test?

https://codereview.chromium.org/2829653002/diff/1/ui/views/corewm/tooltip_con...
File ui/views/corewm/tooltip_controller.cc (right):

https://codereview.chromium.org/2829653002/diff/1/ui/views/corewm/tooltip_con...
ui/views/corewm/tooltip_controller.cc:186: SetTooltipWindow(NULL);
nullptr

https://codereview.chromium.org/2829653002/diff/1/ui/views/corewm/tooltip_con...
ui/views/corewm/tooltip_controller.cc:189: (tooltip_window_ &&
Because you are calling SetTooltipWindow(nullptr) above, |tooltip_window_| will
always be null here, right? So this check should be removed.

[girard, 2017-04-19 21:39:40]

Cleaned up, and added unit test.

https://codereview.chromium.org/2829653002/diff/1/ui/views/corewm/tooltip_con...
File ui/views/corewm/tooltip_controller.cc (right):

https://codereview.chromium.org/2829653002/diff/1/ui/views/corewm/tooltip_con...
ui/views/corewm/tooltip_controller.cc:186: SetTooltipWindow(NULL);
On 2017/04/19 18:31:16, sadrul wrote:
> nullptr

Acknowledged.

https://codereview.chromium.org/2829653002/diff/1/ui/views/corewm/tooltip_con...
ui/views/corewm/tooltip_controller.cc:189: (tooltip_window_ &&
On 2017/04/19 18:31:16, sadrul wrote:
> Because you are calling SetTooltipWindow(nullptr) above, |tooltip_window_|
will
> always be null here, right? So this check should be removed.

Acknowledged.

[sadrul, 2017-04-19 21:48:58]

lgtm

https://codereview.chromium.org/2829653002/diff/2/ui/views/corewm/tooltip_con...
File ui/views/corewm/tooltip_controller_unittest.cc (right):

https://codereview.chromium.org/2829653002/diff/2/ui/views/corewm/tooltip_con...
ui/views/corewm/tooltip_controller_unittest.cc:236: EXPECT_EQ(NULL,
helper_->GetTooltipWindow());
nullptr (and below)

[girard, 2017-04-20 13:21:57]

The CQ bit was checked by girard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 13:22:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[girard, 2017-04-20 16:18:15]

The CQ bit was checked by girard@chromium.org

[girard, 2017-04-20 16:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from ananta@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2829653002/#ps30001
(title: "Unit test cleanup")

[commit-bot: I haz the power, 2017-04-20 16:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[girard, 2017-04-20 16:19:06]

On 2017/04/19 21:48:58, sadrul wrote:
> lgtm
> 
>
https://codereview.chromium.org/2829653002/diff/2/ui/views/corewm/tooltip_con...
> File ui/views/corewm/tooltip_controller_unittest.cc (right):
> 
>
https://codereview.chromium.org/2829653002/diff/2/ui/views/corewm/tooltip_con...
> ui/views/corewm/tooltip_controller_unittest.cc:236: EXPECT_EQ(NULL,
> helper_->GetTooltipWindow());
> nullptr (and below)

Thanks - fixed.

[commit-bot: I haz the power, 2017-04-20 17:22:47]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1492705095408840,
"parent_rev": "aaf5884039a25b4f67eec57428e5e61eade2eaf4", "commit_rev":
"a19d2ff185b04105bf66c835f8bb84b8b5fb79b2"}

[commit-bot: I haz the power, 2017-04-20 17:22:57]

Description was changed from

==========
Removed (spurious, touch-initiated) tooltips from nav buttons

Windows generates WM_MOUSEMOVE buttons at random points (to make sure
that apps know where the cursor is). In some cases the cursor location
was caused by a touch event - the mouse cursor jumps to the last touch
location.

This patch tracks the last touch location so that tooltips can ignore
those extraneous mousemove's.

BUG=698435
==========

to

==========
Removed (spurious, touch-initiated) tooltips from nav buttons

Windows generates WM_MOUSEMOVE buttons at random points (to make sure
that apps know where the cursor is). In some cases the cursor location
was caused by a touch event - the mouse cursor jumps to the last touch
location.

This patch tracks the last touch location so that tooltips can ignore
those extraneous mousemove's.

BUG=698435

Review-Url: https://codereview.chromium.org/2829653002
Cr-Commit-Position: refs/heads/master@{#466046}
Committed:
https://chromium.googlesource.com/chromium/src/+/a19d2ff185b04105bf66c835f8bb...
==========

[commit-bot: I haz the power, 2017-04-20 17:22:58]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/a19d2ff185b04105bf66c835f8bb...