Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2829553002: Remove the dup function (Closed)

Created:
3 years, 8 months ago by hayato
Modified:
3 years, 8 months ago
Reviewers:
tkent, dtapuska
CC:
blink-reviews, blink-reviews-events_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the dup function The context: https://codereview.chromium.org/2807123002#msg83 Use HitTestResult::innerElement, instead of adding EventHandlerUtil::ParentElementIfNeeded(). BUG=708394, 710425 Review-Url: https://codereview.chromium.org/2829553002 Cr-Commit-Position: refs/heads/master@{#465536} Committed: https://chromium.googlesource.com/chromium/src/+/14bcd90c3e83b60fb9ecce8504356b81af4c6209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M third_party/WebKit/Source/core/input/EventHandler.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlingUtil.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlingUtil.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventWithHitTestResults.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hayato
PTAL
3 years, 8 months ago (2017-04-19 03:45:02 UTC) #4
tkent
lgtm
3 years, 8 months ago (2017-04-19 08:41:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829553002/1
3 years, 8 months ago (2017-04-19 08:50:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14bcd90c3e83b60fb9ecce8504356b81af4c6209
3 years, 8 months ago (2017-04-19 08:55:06 UTC) #12
dtapuska
3 years, 8 months ago (2017-04-19 14:25:02 UTC) #13
Message was sent while issue was closed.
On 2017/04/19 08:55:06, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/14bcd90c3e83b60fb9ecce850435...

lgtm.. Thanks for the cleanup!

Powered by Google App Engine
This is Rietveld 408576698