Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp

Issue 2829543002: [DMC #5] Add SpellCheckMarkerListImpl (Closed)
Patch Set: Don't update DocumentMarkerControllerTest in this CL Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
index cbe0675c29da1af6c99e9fd3bfc533ab2d6327d4..0c651b91d0f15daf63a19e49764ebce1db71e4ad 100644
--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.cpp
@@ -17,8 +17,7 @@ void GenericDocumentMarkerListImpl::Add(DocumentMarker* marker) {
switch (marker->GetType()) {
case DocumentMarker::kSpelling:
case DocumentMarker::kGrammar:
- DocumentMarkerListEditor::AddMarkerAndMergeOverlapping(&markers_, marker);
- return;
+ NOTREACHED();
case DocumentMarker::kTextMatch:
DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping(&markers_,
marker);
@@ -51,13 +50,6 @@ bool GenericDocumentMarkerListImpl::RemoveMarkers(unsigned start_offset,
length);
}
-bool GenericDocumentMarkerListImpl::RemoveMarkersUnderWords(
- const String& node_text,
- const Vector<String>& words) {
- return DocumentMarkerListEditor::RemoveMarkersUnderWords(&markers_, node_text,
- words);
-}
-
bool GenericDocumentMarkerListImpl::ShiftMarkers(unsigned offset,
unsigned old_length,
unsigned new_length) {

Powered by Google App Engine
This is Rietveld 408576698