[DMC #5] Add SpellCheckMarkerListImpl

third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
index 0e23593766962c11d7b8bb844db704ffee0dff20..88cacf5d5d3680e1f4ed43481ab0ae568d7039f3 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
@@ -72,8 +72,8 @@ void DocumentMarkerControllerTest::MarkNodeContents(Node* node) {
   // DocumentMarkerControllerTest::addMarker(), needs them.
   GetDocument().UpdateStyleAndLayout();
   auto range = EphemeralRange::RangeOfContents(*node);
-  MarkerController().AddMarker(range.StartPosition(), range.EndPosition(),

[Xiaocheng, 2017/04/27 22:04:38]

Are these the only sites creating markers of wrong types?

It seems better to clean up all of them in a separate patch.

[rlanday, 2017/04/27 22:22:23]

No, these are actually correctly creating Spelling markers, but we actually want
TextMatch
markers because those are eventually going to be the only ones with
RenderedRects. We
could do this later (when we get rid of the RenderedRects in the non-TextMatch
marker list
impls) if we want.

-                               DocumentMarker::kSpelling);
+  MarkerController().AddTextMatchMarker(range,
+                                        DocumentMarker::MatchStatus::kInactive);
 }
 
 void DocumentMarkerControllerTest::SetBodyInnerHTML(const char* body_content) {
@@ -195,13 +195,13 @@ TEST_F(DocumentMarkerControllerTest, UpdateRenderedRects) {
   Element* div = ToElement(GetDocument().body()->firstChild());
   MarkNodeContents(div);
   Vector<IntRect> rendered_rects =
-      MarkerController().RenderedRectsForMarkers(DocumentMarker::kSpelling);
+      MarkerController().RenderedRectsForMarkers(DocumentMarker::kTextMatch);
   EXPECT_EQ(1u, rendered_rects.size());
 
   div->setAttribute(HTMLNames::styleAttr, "margin: 200px");
   GetDocument().UpdateStyleAndLayout();
   Vector<IntRect> new_rendered_rects =
-      MarkerController().RenderedRectsForMarkers(DocumentMarker::kSpelling);
+      MarkerController().RenderedRectsForMarkers(DocumentMarker::kTextMatch);
   EXPECT_EQ(1u, new_rendered_rects.size());
   EXPECT_NE(rendered_rects[0], new_rendered_rects[0]);
 }