[Home] Close the BottomSheet when a URL is loaded on the NTP

[Home] Close the BottomSheet when a URL is loaded on the NTP

This ensures that a click on the doodle will close the BottomSheet.

BUG=712607
Review-Url: https://codereview.chromium.org/2829523002
Cr-Commit-Position: refs/heads/master@{#465604}
Committed: https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a2445acf5a9ed05

[Theresa, 2017-04-18 22:56:45]

twellington@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Theresa, 2017-04-18 22:56:46]

ptal

[Michael van Ouwerkerk, 2017-04-19 09:10:27]

lgtm

[Michael van Ouwerkerk, 2017-04-19 09:10:33]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 09:11:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 09:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 09:48:29]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-04-19 14:57:19]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2017-04-19 14:57:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 15:02:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492613839620700, "parent_rev":
"cef9e211832bf2d1f01f750296238fed28e416f0", "commit_rev":
"2a80017ed38340c00d1d214a3a2445acf5a9ed05"}

[commit-bot: I haz the power, 2017-04-19 15:02:51]

Description was changed from

==========
[Home] Close the BottomSheet when a URL is loaded on the NTP

This ensures that a click on the doodle will close the BottomSheet.

BUG=712607
==========

to

==========
[Home] Close the BottomSheet when a URL is loaded on the NTP

This ensures that a click on the doodle will close the BottomSheet.

BUG=712607

Review-Url: https://codereview.chromium.org/2829523002
Cr-Commit-Position: refs/heads/master@{#465604}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a24...
==========

[commit-bot: I haz the power, 2017-04-19 15:02:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a24...

[Theresa, 2017-04-19 20:11:45]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2830743003/ by twellington@chromium.org.

The reason for reverting is: Broke Lollipop Tester

junit.framework.AssertionFailedError: Sheet should be at half height
expected:<1> but was:<3>
	at
org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.validateState(ChromeHomeNewTabPageTest.java:197)
	at
org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.createNewTab(ChromeHomeNewTabPageTest.java:168)
	at
org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.testCloseNTP_TwoTabs(ChromeHomeNewTabPageTest.java:92)
	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at
org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at
org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853).