Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2829483002: [wasm] Implement first set of SIMD I8x16 ops (Closed)

Created:
3 years, 8 months ago by gdeepti
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, bradnelson
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Implement first set of SIMD I8x16 ops - I8x16Splat, I8x16ExtractLane, I8x16ReplaceLane - Binops: I8x16Add, I8x16AddSaturateS, I8x16Sub, I8x16SubSaturateS, I8x16MinS, I8x16MaxS, I8x16AddSaturateU, I8x16SubSaturateU, I8x16MinU, I8x16MaxU - Compare ops: I8x16Eq, I8x16Ne BUG=v8:6020 R=bbudge@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2829483002 Cr-Commit-Position: refs/heads/master@{#44706} Committed: https://chromium.googlesource.com/v8/v8/+/635eea88e58f264f7b2b3bfb32e0eca6ec2e8145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -14 lines) Patch
M src/compiler/instruction-selector.cc View 7 chunks +16 lines, -4 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +17 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 6 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gdeepti
3 years, 8 months ago (2017-04-18 22:16:06 UTC) #3
bbudge
lgtm
3 years, 8 months ago (2017-04-18 23:01:09 UTC) #6
Mircea Trofin
On 2017/04/18 23:01:09, bbudge wrote: > lgtm rubberstamp lgtm
3 years, 8 months ago (2017-04-18 23:18:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829483002/1
3 years, 8 months ago (2017-04-18 23:21:34 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:23:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/635eea88e58f264f7b2b3bfb32e0eca6ec2...

Powered by Google App Engine
This is Rietveld 408576698