Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2829463004: Fix double listing of vr_export.h in BUILD.gn (Closed)

Created:
3 years, 8 months ago by nhu
Modified:
3 years, 8 months ago
Reviewers:
mthiesse, bajones, billorr
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix double listing of vr_export.h in BUILD.gn BUG=713009 Review-Url: https://codereview.chromium.org/2829463004 Cr-Commit-Position: refs/heads/master@{#465620} Committed: https://chromium.googlesource.com/chromium/src/+/11dd1d920e974ab8734ef9808f8001cf03f18dcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M device/vr/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
nhu
PTAL. Thanks!
3 years, 8 months ago (2017-04-19 07:33:38 UTC) #3
mthiesse
lgtm
3 years, 8 months ago (2017-04-19 14:23:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829463004/1
3 years, 8 months ago (2017-04-19 14:24:13 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:45:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11dd1d920e974ab8734ef9808f80...

Powered by Google App Engine
This is Rietveld 408576698