Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2829463002: Replace TestHeadersHandler::OnHeaderBlockEnd body with call to other method. (Closed)

Created:
3 years, 8 months ago by Bence
Modified:
3 years, 8 months ago
Reviewers:
diannahu, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace TestHeadersHandler::OnHeaderBlockEnd body with call to other method. This CL lands part of server change 153489255. BUG=488484 Review-Url: https://codereview.chromium.org/2829463002 Cr-Commit-Position: refs/heads/master@{#465727} Committed: https://chromium.googlesource.com/chromium/src/+/3b92d36f19d01005f2416e73f64addaa7f42c422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/spdy/spdy_test_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bence
Dianna: PTAL. Thank you.
3 years, 8 months ago (2017-04-18 20:39:13 UTC) #4
diannahu
lgtm
3 years, 8 months ago (2017-04-18 21:44:16 UTC) #7
Bence
xunjieli: PTAL. Thank you.
3 years, 8 months ago (2017-04-19 12:04:33 UTC) #9
xunjieli
On 2017/04/19 12:04:33, Bence wrote: > xunjieli: PTAL. Thank you. lgtm!
3 years, 8 months ago (2017-04-19 15:12:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829463002/1
3 years, 8 months ago (2017-04-19 20:11:17 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 20:16:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b92d36f19d01005f2416e73f64a...

Powered by Google App Engine
This is Rietveld 408576698