Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2829453002: [Extensions] Remove unnecessary check in app_custom_bindings.js (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove unnecessary check in app_custom_bindings.js app_custom_bindings.js checks for if 'app' is available, but doesn't need to - if it's unavailable, the getter will never be added to the chrome object, and the custom bindings will never be called. BUG=None Review-Url: https://codereview.chromium.org/2829453002 Cr-Commit-Position: refs/heads/master@{#465615} Committed: https://chromium.googlesource.com/chromium/src/+/32929d130be20847d1b4b7a54e07026f273a25f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/renderer/resources/extensions/app_custom_bindings.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Devlin
3 years, 8 months ago (2017-04-19 00:26:45 UTC) #6
lazyboy
lgtm
3 years, 8 months ago (2017-04-19 02:06:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829453002/1
3 years, 8 months ago (2017-04-19 15:25:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:31:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32929d130be20847d1b4b7a54e07...

Powered by Google App Engine
This is Rietveld 408576698