Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2829443002: Give Background Fetch downloads an explicit path on Android (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
shaktisahu
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Give Background Fetch downloads an explicit path on Android This avoids getting the "due to missing SD card" message when trying the feature on an Android device. BUG=710001 Review-Url: https://codereview.chromium.org/2829443002 Cr-Commit-Position: refs/heads/master@{#465375} Committed: https://chromium.googlesource.com/chromium/src/+/73a67a97d85aa723309374bd27283eeda1757165

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M content/browser/background_fetch/background_fetch_job_controller.cc View 2 chunks +29 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (8 generated)
Peter Beverloo
+shaktisahu for review
3 years, 8 months ago (2017-04-18 19:10:42 UTC) #3
shaktisahu
lgtm lgtm https://codereview.chromium.org/2829443002/diff/1/content/browser/background_fetch/background_fetch_job_controller.cc File content/browser/background_fetch/background_fetch_job_controller.cc (right): https://codereview.chromium.org/2829443002/diff/1/content/browser/background_fetch/background_fetch_job_controller.cc#newcode33 content/browser/background_fetch/background_fetch_job_controller.cc:33: // indicate files thta were fetched through ...
3 years, 8 months ago (2017-04-18 20:16:56 UTC) #7
Peter Beverloo
Thank you! :) I'll fix the typo in a follow-up, hoping to get this in ...
3 years, 8 months ago (2017-04-18 21:08:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829443002/1
3 years, 8 months ago (2017-04-18 21:08:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:13:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73a67a97d85aa723309374bd2728...

Powered by Google App Engine
This is Rietveld 408576698