Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2829433002: DevTools: hide the replace input when it replace is disabled (Closed)

Created:
3 years, 8 months ago by luoe
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: hide the replace input when it replace is disabled BUG=712472 Review-Url: https://codereview.chromium.org/2829433002 Cr-Commit-Position: refs/heads/master@{#465854} Committed: https://chromium.googlesource.com/chromium/src/+/f5f56eaf9aa0338be5de51380df8cf90814e2444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
luoe
Please take a look. I was not hiding the replace input when it should have ...
3 years, 8 months ago (2017-04-18 19:03:11 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-04-19 20:39:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829433002/1
3 years, 8 months ago (2017-04-20 00:02:51 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 01:47:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5f56eaf9aa0338be5de51380df8...

Powered by Google App Engine
This is Rietveld 408576698