[MD settings] change spacing between controlledBy icon and control

[MD settings] change spacing between controlledBy icon and control

This CL changes the distance between the controlledBy icon and the control being restricted. This distance was 18px and it is now 24px. Also, the use of the changed variable was removed from the tool bar where it was used as an icon offset (which is to remain at 18px).

BUG=714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2829373003
Cr-Commit-Position: refs/heads/master@{#470408}
Committed: https://chromium.googlesource.com/chromium/src/+/dfef613f078ed5cddcff6ff82037aac8f0473036

[dschuyler, 2017-04-22 01:32:48]

Description was changed from

==========
[MD settings] inherit padding and margin in controlled button

This CL passes the left and right margins and padding through the
controlled-button.

BUG=714352
==========

to

==========
[MD settings] inherit padding and margin in controlled button

This CL passes the left and right margins and padding through the
controlled-button.

BUG=714352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-22 01:32:50]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 01:33:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-22 01:43:55]

Description was changed from

==========
[MD settings] inherit padding and margin in controlled button

This CL passes the left and right margins and padding through the
controlled-button.

BUG=714352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Not ready for review. The controlledBy indicator is misplaced with this CL.




[MD settings] inherit padding and margin in controlled button

This CL passes the left and right margins and padding through the
controlled-button.

BUG=714352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-04-22 02:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 02:57:42]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-04-26 20:18:51]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 20:19:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-26 20:27:12]

Description was changed from

==========
Not ready for review. The controlledBy indicator is misplaced with this CL.




[MD settings] inherit padding and margin in controlled button

This CL passes the left and right margins and padding through the
controlled-button.

BUG=714352
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] secondary-action layout changes

This CL changes how secondary-action (CSS) are laid out. The 
secondary-action is now zero width and the contents of the element space
out the elements. This makes Issue 714320 more tractable.

BUG=714352, 714320, 714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-26 20:28:46]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[dschuyler, 2017-04-26 20:28:47]

This could be split into several bugs and I'm happy to do that if you'd prefer
it.

[dschuyler, 2017-04-26 20:29:20]

On 2017/04/26 20:28:47, dschuyler wrote:
> This could be split into several bugs and I'm happy to do that if you'd prefer
> it.

ERr, I meant several CL's -- it's fixing several bugs -- I can split them up if
you prefer.

[Dan Beam, 2017-04-26 20:48:29]

this generally seems fine to me, can you send before+after screenshots?

https://codereview.chromium.org/2829373003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2829373003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:40:
-webkit-margin-start:calc(
nit: space after :

[dschuyler, 2017-04-26 21:05:41]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 21:06:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-04-26 21:39:44]

we just talked about this in-person: we could also try just composing vertical
separators and using more traditional flex layout (rather than explicit classes)

[commit-bot: I haz the power, 2017-04-26 22:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:47:48]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-05-02 22:06:13]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 22:06:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-02 22:46:19]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 22:46:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-02 22:58:00]

Patchset #4 (id:60001) has been deleted

[dschuyler, 2017-05-02 23:05:50]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 23:06:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-02 23:06:25]

Patchset #4 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-05-02 23:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 23:21:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dschuyler, 2017-05-02 23:27:15]

Description was changed from

==========
[MD settings] secondary-action layout changes

This CL changes how secondary-action (CSS) are laid out. The 
secondary-action is now zero width and the contents of the element space
out the elements. This makes Issue 714320 more tractable.

BUG=714352, 714320, 714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] secondary-action layout changes

This CL changes how secondary-action (CSS) are laid out. The 
secondary-action class has been replaced by a separator class. The new class is
used independently of the secondary action controls rather than as a container
for the secondary action controls. This makes Issue 714320 more tractable.

BUG=714352, 714320, 714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-02 23:44:19]

The separator work was separated out :)

[dschuyler, 2017-05-03 00:47:17]

On 2017/05/02 23:44:19, dschuyler wrote:
> The separator work was separated out :)

Oh, forgot to mention, screen shots have been added to the bugs. (And as a
bonus, those screen shots have been reviewed by Alan).

[Dan Beam, 2017-05-08 18:03:50]

i can't really understand from the bug and the other CLs whether this is needed
or the end results.

can you clarify this and maybe update the CL description to be more concrete? 
as in: "Change padding between secondary actions from 16px to 24px" or
something?

[dschuyler, 2017-05-08 21:10:39]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:11:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-05-08 21:14:11]

Description was changed from

==========
[MD settings] secondary-action layout changes

This CL changes how secondary-action (CSS) are laid out. The 
secondary-action class has been replaced by a separator class. The new class is
used independently of the secondary action controls rather than as a container
for the secondary action controls. This makes Issue 714320 more tractable.

BUG=714352, 714320, 714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] changed spacing between controlledBy icon and control

This CL changes the distance between the controlledBy icon and the control being
restricted. This distance was 18px and it is now 24px. Also, the use of the
changed variable was removed from the tool bar where it was used as an icon
offset (which is to remain at 18px).

BUG=714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-08 21:14:20]

Description was changed from

==========
[MD settings] changed spacing between controlledBy icon and control

This CL changes the distance between the controlledBy icon and the control being
restricted. This distance was 18px and it is now 24px. Also, the use of the
changed variable was removed from the tool bar where it was used as an icon
offset (which is to remain at 18px).

BUG=714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] change spacing between controlledBy icon and control

This CL changes the distance between the controlledBy icon and the control being
restricted. This distance was 18px and it is now 24px. Also, the use of the
changed variable was removed from the tool bar where it was used as an icon
offset (which is to remain at 18px).

BUG=714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-08 21:16:31]

On 2017/05/08 21:15:15, dschuyler wrote:

I focused the CL on the policy icon shift and changed the CL description.

[Dan Beam, 2017-05-08 21:24:37]

lgtm

[commit-bot: I haz the power, 2017-05-09 01:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:21:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dschuyler, 2017-05-09 01:31:52]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:33:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 02:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 02:21:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dschuyler, 2017-05-09 18:10:44]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-05-09 18:10:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2829373003/#ps140001
(title: "merge with master")

[commit-bot: I haz the power, 2017-05-09 18:12:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 19:35:42]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1494353444797350,
"parent_rev": "bccbe7c22a38f68da0c4d0bb9258060f2554e318", "commit_rev":
"dfef613f078ed5cddcff6ff82037aac8f0473036"}

[commit-bot: I haz the power, 2017-05-09 19:35:50]

Description was changed from

==========
[MD settings] change spacing between controlledBy icon and control

This CL changes the distance between the controlledBy icon and the control being
restricted. This distance was 18px and it is now 24px. Also, the use of the
changed variable was removed from the tool bar where it was used as an icon
offset (which is to remain at 18px).

BUG=714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] change spacing between controlledBy icon and control

This CL changes the distance between the controlledBy icon and the control being
restricted. This distance was 18px and it is now 24px. Also, the use of the
changed variable was removed from the tool bar where it was used as an icon
offset (which is to remain at 18px).

BUG=714919
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2829373003
Cr-Commit-Position: refs/heads/master@{#470408}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfef613f078ed5cddcff6ff82037...
==========

[commit-bot: I haz the power, 2017-05-09 19:35:53]

Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/dfef613f078ed5cddcff6ff82037...