Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 2829363002: Log absolute foreground duration for page loads before and after paint in from gws observer and cor… (Closed)
Patch Set: Change the suffix names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index b2112f0d82ca21c4524e7e7b55a4a86f3a14a5e6..c39d1c97f7248ee6589d6c9adfdd0422dcd32f31 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -101,6 +101,12 @@ const char kHistogramFromGWSForegroundDuration[] =
const char kHistogramFromGWSForegroundDurationAfterPaint[] =
"PageLoad.Clients.FromGoogleSearch.PageTiming.ForegroundDuration."
"AfterPaint";
+const char kHistogramFromGWSForegroundDurationWithPaint[] =
+ "PageLoad.Clients.FromGoogleSearch.PageTiming.ForegroundDuration."
+ "WithPaint";
+const char kHistogramFromGWSForegroundDurationWithoutPaint[] =
+ "PageLoad.Clients.FromGoogleSearch.PageTiming.ForegroundDuration."
+ "WithoutPaint";
const char kHistogramFromGWSForegroundDurationNoCommit[] =
"PageLoad.Clients.FromGoogleSearch.PageTiming.ForegroundDuration.NoCommit";
@@ -239,6 +245,13 @@ void LogForegroundDurations(const page_load_metrics::PageLoadTiming& timing,
internal::kHistogramFromGWSForegroundDurationAfterPaint,
foreground_duration.value() -
timing.paint_timing.first_paint.value());
+ PAGE_LOAD_LONG_HISTOGRAM(
+ internal::kHistogramFromGWSForegroundDurationWithPaint,
+ foreground_duration.value());
+ } else {
+ PAGE_LOAD_LONG_HISTOGRAM(
+ internal::kHistogramFromGWSForegroundDurationWithoutPaint,
+ foreground_duration.value());
}
} else {
PAGE_LOAD_LONG_HISTOGRAM(

Powered by Google App Engine
This is Rietveld 408576698