Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4350)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2829363002: Log absolute foreground duration for page loads before and after paint in from gws observer and cor… (Closed)
Patch Set: Change the suffix names. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 51a8e9eb736effa11a62bc0e49fa1182d1c809f1..51e236bab15cd9b2ed970706a6006ced0944a9d5 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -164,6 +164,10 @@ const char kHistogramPageTimingForegroundDurationAfterPaint[] =
"PageLoad.PageTiming.ForegroundDuration.AfterPaint";
const char kHistogramPageTimingForegroundDurationNoCommit[] =
"PageLoad.PageTiming.ForegroundDuration.NoCommit";
+const char kHistogramPageTimingForegroundDurationWithPaint[] =
+ "PageLoad.PageTiming.ForegroundDuration.WithPaint";
+const char kHistogramPageTimingForegroundDurationWithoutPaint[] =
+ "PageLoad.PageTiming.ForegroundDuration.WithoutPaint";
const char kHistogramLoadTypeParseStartReload[] =
"PageLoad.ParseTiming.NavigationToParseStart.LoadType.Reload";
@@ -741,6 +745,13 @@ void CorePageLoadMetricsObserver::RecordForegroundDurationHistograms(
internal::kHistogramPageTimingForegroundDurationAfterPaint,
foreground_duration.value() -
timing.paint_timing.first_paint.value());
+ PAGE_LOAD_LONG_HISTOGRAM(
+ internal::kHistogramPageTimingForegroundDurationWithPaint,
+ foreground_duration.value());
+ } else {
+ PAGE_LOAD_LONG_HISTOGRAM(
+ internal::kHistogramPageTimingForegroundDurationWithoutPaint,
+ foreground_duration.value());
}
} else {
PAGE_LOAD_LONG_HISTOGRAM(

Powered by Google App Engine
This is Rietveld 408576698