Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2829343002: Initialize the media_log_ pointer in MPEGStreamParserBase. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize the media_log_ pointer in MPEGStreamParserBase. The ADTSStreamParser is used without initialization, so it doesn't have a valid media_log, it null checks this -- but since a recent change moved MediaLog from a ref ptr to raw we missed initialize. BUG=713515 TEST=none Review-Url: https://codereview.chromium.org/2829343002 Cr-Commit-Position: refs/heads/master@{#466530} Committed: https://chromium.googlesource.com/chromium/src/+/33317059948e1bc31d86c5918fba4bab0a62a373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/formats/mpeg/mpeg_audio_stream_parser_base.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
DaleCurtis
3 years, 8 months ago (2017-04-21 22:39:41 UTC) #2
wolenetz
lgtm. ISTM the lack of ADTSStreamParser::Init() call in some paths is just happening in the ...
3 years, 8 months ago (2017-04-21 23:31:36 UTC) #3
wolenetz
On 2017/04/21 23:31:36, wolenetz wrote: > lgtm. ISTM the lack of ADTSStreamParser::Init() call in some ...
3 years, 8 months ago (2017-04-21 23:34:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829343002/1
3 years, 8 months ago (2017-04-22 00:06:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/436901)
3 years, 8 months ago (2017-04-22 01:58:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829343002/1
3 years, 8 months ago (2017-04-22 02:21:10 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 02:54:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33317059948e1bc31d86c5918fba...

Powered by Google App Engine
This is Rietveld 408576698