Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2829263002: [Android O] Only delete legacy notification channels on upgrade (Closed)

Created:
3 years, 8 months ago by awdf
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Android O] Only delete legacy notification channels on upgrade - Now instead of deleting all channels on upgrade, we only delete those we know to be legacy channels. - This fixes a crash where we tried to delete the default channel created by Android causing an IllegalArgumentException. BUG=710843 Review-Url: https://codereview.chromium.org/2832493002 Cr-Commit-Position: refs/heads/master@{#466352} (cherry picked from commit e0bb8b3085974f05fcb8c2a8f65a8585d749264f) Review-Url: https://codereview.chromium.org/2829263002 . Cr-Commit-Position: refs/branch-heads/3071@{#121} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/5f662891d23246fb57e349185b57cfa663a9db6b

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
awdf
3 years, 8 months ago (2017-04-21 17:01:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f662891d23246fb57e349185b57cfa663a9db6b.

Powered by Google App Engine
This is Rietveld 408576698