Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2829233002: Remove the unsed code for showing Toast after shortcut added by O API. (Closed)

Created:
3 years, 8 months ago by Marti Wong
Modified:
3 years, 8 months ago
Reviewers:
dominickn, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unsed code for showing Toast after shortcut added by O API. In https://chrome-internal-review.googlesource.com/c/356025, we disabled the toast after shortcut added to homescreen using Android O's API. This CL is to remove the unsed code in Chrome's public repository. BUG=714420 Review-Url: https://codereview.chromium.org/2829233002 Cr-Commit-Position: refs/heads/master@{#466577} Committed: https://chromium.googlesource.com/chromium/src/+/cf6ef1f8eddd620ccbfc3339aaa34f944462af52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 3 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Marti Wong
PTAL. thanks~!
3 years, 8 months ago (2017-04-21 05:23:19 UTC) #2
dominickn
lgtm, thanks!
3 years, 8 months ago (2017-04-21 05:37:11 UTC) #3
gone
lgtm
3 years, 8 months ago (2017-04-21 21:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829233002/1
3 years, 8 months ago (2017-04-24 02:00:20 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 02:04:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf6ef1f8eddd620ccbfc3339aaa3...

Powered by Google App Engine
This is Rietveld 408576698