Add setter to Isolate for allowing Atomics.wait

Add setter to Isolate for allowing Atomics.wait

This makes it easier to set the value for embedders where it is
difficult to plumb through to the Isolate constructor.

BUG=chromium:711809
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2829223002
Cr-Commit-Position: refs/heads/master@{#44813}
Committed: https://chromium.googlesource.com/v8/v8/+/3cc88456804ebe0f989f12353202b9dc768f6669

[binji, 2017-04-21 01:41:07]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 01:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 02:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 02:07:58]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-04-21 08:42:14]

can you add a test for this?

I also wonder whether it would make sense to make this a per-context setting
instead?

[binji, 2017-04-21 18:24:31]

On 2017/04/21 at 08:42:14, jochen wrote:
> can you add a test for this?

Done.

> 
> I also wonder whether it would make sense to make this a per-context setting
instead?

Not sure. It seems a bit odd to me, but I guess the question is whether one
context in an isolate would allow blocking where another context wouldn't. That
seems unlikely, but I have to admit I don't know a lot about how these things
are used.

[binji, 2017-04-21 18:24:37]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 18:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 18:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 18:53:30]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-04-24 09:49:13]

On 2017/04/21 at 18:24:31, binji wrote:
> On 2017/04/21 at 08:42:14, jochen wrote:
> > can you add a test for this?
> 
> Done.
> 
> > 
> > I also wonder whether it would make sense to make this a per-context setting
instead?
> 
> Not sure. It seems a bit odd to me, but I guess the question is whether one
context in an isolate would allow blocking where another context wouldn't. That
seems unlikely, but I have to admit I don't know a lot about how these things
are used.

It's possible to run the same Isolate on multiple threads, I guess this might
happen in that scenario.

However, we can still cross that bridge once somebody wants to use that, so lgtm

[binji, 2017-04-24 18:35:27]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:35:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 19:08:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493058927732390,
"parent_rev": "a71c338d9e24e55b47125108a0fce754076751d0", "commit_rev":
"3cc88456804ebe0f989f12353202b9dc768f6669"}

[commit-bot: I haz the power, 2017-04-24 19:08:29]

Description was changed from

==========
Add setter to Isolate for allowing Atomics.wait

This makes it easier to set the value for embedders where it is
difficult to plumb through to the Isolate constructor.

BUG=chromium:711809
R=jochen@chromium.org
==========

to

==========
Add setter to Isolate for allowing Atomics.wait

This makes it easier to set the value for embedders where it is
difficult to plumb through to the Isolate constructor.

BUG=chromium:711809
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2829223002
Cr-Commit-Position: refs/heads/master@{#44813}
Committed:
https://chromium.googlesource.com/v8/v8/+/3cc88456804ebe0f989f12353202b9dc768...
==========

[commit-bot: I haz the power, 2017-04-24 19:08:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3cc88456804ebe0f989f12353202b9dc768...