Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2829213002: Clean up ComputedStyle field templates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by shend
Modified:
1 week, 1 day ago
Reviewers:
nainar
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ComputedStyle field templates. This patch reduces code duplication by making the macros in field.tmpl and base.tmpl more generic and granular. - Rename argument_type(field) -> const_ref(field) - Rename return_type(field) -> nonconst_ref(field) - Split base.decl_public_methods into: - base.decl_initial_method - base.decl_getter_method - base.decl_setter_method - base.decl_resetter_method - Split base.decl_protected_methods into: - base.decl_mutable_method - base.decl_internal_getter_method - base.decl_internal_setter_method Diff of generated files: https://gist.github.com/darrnshn/a4f1071f9901d5d4b321ebd166c10dfa/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2829213002 Cr-Commit-Position: refs/heads/master@{#466255} Committed: https://chromium.googlesource.com/chromium/src/+/a83d36d99006b177f36fccbe214fdc3614ec8486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -41 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl View 1 chunk +27 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/keyword.tmpl View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/monotonic_flag.tmpl View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/primitive.tmpl View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl View 1 chunk +8 lines, -16 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (9 generated)
shend
Hi Naina, PTAL :)
1 week, 1 day ago (2017-04-21 01:39:22 UTC) #5
nainar
lgtm
1 week, 1 day ago (2017-04-21 03:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829213002/1
1 week, 1 day ago (2017-04-21 04:05:03 UTC) #10
commit-bot: I haz the power
1 week, 1 day ago (2017-04-21 04:10:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a83d36d99006b177f36fccbe214f...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46