[autoroller] All commits in updates(), only roll interesting ones.

[autoroller] All commits in updates(), only roll interesting ones.

Previously `updates` would only include the 'interesting' updates, which
meant that the new autoroller algorithm skips over chunks of the repo
history. If multiple repos have chunks of non-interesting history, the
autoroller can end up not proposing any good candidates.

This CL simplifies the repo interface by having `updates()` always
return the full list of commits, but adds a new field to the
CommitMetadata which indicates that a given commit was `interesting`.
This way the full history of every repo is available when picking
candidates (e.g. for `CommitList.advance_to`), but find_best_rev will
only consider rolling to interesting commits.

Originally landed: https://codereview.chromium.org/2833723003

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2829203002
Committed: https://github.com/luci/recipes-py/commit/763b5442fe13969bc3ffc0fa37bcc527fa9814bf

[dnj, 2017-04-21 00:05:06]

lgtm from last time, carrots seemed to work on Windows box.

[dnj, 2017-04-21 00:06:08]

On 2017/04/21 00:05:06, dnj wrote:
> lgtm from last time, carrots seemed to work on Windows box.

lol carats

[iannucci, 2017-04-21 00:06:11]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-04-21 00:06:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 00:09:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492733171278780,
"parent_rev": "84d216aab872ff9d2ea18a39620fec428ea38e57", "commit_rev":
"763b5442fe13969bc3ffc0fa37bcc527fa9814bf"}

[commit-bot: I haz the power, 2017-04-21 00:09:30]

Description was changed from

==========
[autoroller] All commits in updates(), only roll interesting ones.

Previously `updates` would only include the 'interesting' updates, which
meant that the new autoroller algorithm skips over chunks of the repo
history. If multiple repos have chunks of non-interesting history, the
autoroller can end up not proposing any good candidates.

This CL simplifies the repo interface by having `updates()` always
return the full list of commits, but adds a new field to the
CommitMetadata which indicates that a given commit was `interesting`.
This way the full history of every repo is available when picking
candidates (e.g. for `CommitList.advance_to`), but find_best_rev will
only consider rolling to interesting commits.

Originally landed: https://codereview.chromium.org/2833723003

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
==========

to

==========
[autoroller] All commits in updates(), only roll interesting ones.

Previously `updates` would only include the 'interesting' updates, which
meant that the new autoroller algorithm skips over chunks of the repo
history. If multiple repos have chunks of non-interesting history, the
autoroller can end up not proposing any good candidates.

This CL simplifies the repo interface by having `updates()` always
return the full list of commits, but adds a new field to the
CommitMetadata which indicates that a given commit was `interesting`.
This way the full history of every repo is available when picking
candidates (e.g. for `CommitList.advance_to`), but find_best_rev will
only consider rolling to interesting commits.

Originally landed: https://codereview.chromium.org/2833723003

R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2829203002
Committed:
https://github.com/luci/recipes-py/commit/763b5442fe13969bc3ffc0fa37bcc527fa9...
==========

[commit-bot: I haz the power, 2017-04-21 00:09:30]

Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/763b5442fe13969bc3ffc0fa37bcc527fa9...

[iannucci, 2017-04-21 00:22:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2837493002/ by iannucci@chromium.org.

The reason for reverting is: somehow this is still broken....