Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Issue 2829123002: Save and restore DISPLAY so that results.html can be shown. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, kochi
CC:
blink-reviews, chromium-reviews, kochi, mithro, Raphael Kubo da Costa (rakuco)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Save and restore DISPLAY so that results.html can be shown. BUG=711515 Review-Url: https://codereview.chromium.org/2829123002 Cr-Commit-Position: refs/heads/master@{#466084} Committed: https://chromium.googlesource.com/chromium/src/+/e4e29231f2da03e0f447b5d4cbc2a4278bb9223e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
qyearsley
The original CL that made run-webkit-tests start xvfb changed DISPLAY for the run-webkit-tests process, and ...
3 years, 8 months ago (2017-04-20 16:51:24 UTC) #2
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-20 16:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829123002/1
3 years, 8 months ago (2017-04-20 17:08:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e4e29231f2da03e0f447b5d4cbc2a4278bb9223e
3 years, 8 months ago (2017-04-20 18:46:32 UTC) #8
kochi
3 years, 8 months ago (2017-04-24 08:49:51 UTC) #10
Message was sent while issue was closed.
Thanks for the fix!

Powered by Google App Engine
This is Rietveld 408576698