Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2829103002: [Web Payments] Properly constrain label width in order summary (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Properly constrain label width in order summary BUG=711052 Review-Url: https://codereview.chromium.org/2829103002 Cr-Commit-Position: refs/heads/master@{#466671} Committed: https://chromium.googlesource.com/chromium/src/+/29488693e08129987436199a7adf060b5a83d38f

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/views/payments/order_summary_view_controller.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
anthonyvd
Hi Math, PTAL!
3 years, 8 months ago (2017-04-20 14:17:36 UTC) #2
Mathieu
Simple enough! Might want to comment in the code this subtlety. lgtm
3 years, 8 months ago (2017-04-23 08:18:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829103002/20001
3 years, 8 months ago (2017-04-24 13:35:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437377)
3 years, 8 months ago (2017-04-24 16:01:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829103002/20001
3 years, 8 months ago (2017-04-24 16:41:58 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 17:37:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/29488693e08129987436199a7adf...

Powered by Google App Engine
This is Rietveld 408576698