Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2829093002: [turbofan] Avoid creating singleton state-values for the accumulator. (Closed)

Created:
3 years, 8 months ago by Jarin
Modified:
3 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid creating singleton state-values for the accumulator. This saves about 5% of memory and node count consumed by graph building on the TypeScript benchmark. High watermark goes down by 3-4%. BUG=v8:5267 Review-Url: https://codereview.chromium.org/2829093002 Cr-Commit-Position: refs/heads/master@{#45113} Committed: https://chromium.googlesource.com/v8/v8/+/f47572f3a780a022b9198bc59ebae9bcda8f220c

Patch Set 1 #

Patch Set 2 : Improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -17 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +47 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
Jarin
Could you take a look, please?
3 years, 8 months ago (2017-04-20 14:25:50 UTC) #6
Michael Starzinger
LGTM.
3 years, 8 months ago (2017-04-21 11:43:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829093002/20001
3 years, 7 months ago (2017-05-04 19:32:21 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 19:35:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f47572f3a780a022b9198bc59ebae9bcda8...

Powered by Google App Engine
This is Rietveld 408576698