Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282903002: [webcrypto] Remove RSA-ES support (2 of 3) (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More simplification #

Patch Set 3 : rebase #

Patch Set 4 : Rebase and merge conflicts (yuck) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1001 lines) Patch
M content/child/webcrypto/jwk.cc View 1 2 3 4 chunks +1 line, -16 lines 0 comments Download
M content/child/webcrypto/platform_crypto.h View 1 2 3 4 chunks +0 lines, -34 lines 0 comments Download
M content/child/webcrypto/platform_crypto_nss.cc View 1 2 3 8 chunks +2 lines, -156 lines 0 comments Download
M content/child/webcrypto/platform_crypto_openssl.cc View 1 2 3 3 chunks +0 lines, -33 lines 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 1 2 3 12 chunks +17 lines, -86 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 3 20 chunks +90 lines, -646 lines 0 comments Download
M content/child/webcrypto/status.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/child/webcrypto/webcrypto_impl.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
D content/test/data/webcrypto/rsa_es.json View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
eroman
6 years, 7 months ago (2014-05-13 21:31:39 UTC) #1
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-13 22:06:55 UTC) #2
eroman
PTAL at patshet 2. (Needed some additional changes for blink side).
6 years, 7 months ago (2014-05-13 22:08:33 UTC) #3
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-13 22:17:00 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 19:25:12 UTC) #5
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 19:28:48 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 19:38:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/282903002/80001
6 years, 7 months ago (2014-05-21 19:58:28 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 10:29:54 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:32:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9717)
6 years, 7 months ago (2014-05-22 10:32:05 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-22 13:50:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/282903002/80001
6 years, 7 months ago (2014-05-22 13:52:49 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 13:56:04 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 13:58:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9717)
6 years, 7 months ago (2014-05-22 13:58:12 UTC) #16
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-23 15:21:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/282903002/100001
6 years, 7 months ago (2014-05-23 15:22:08 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 18:59:16 UTC) #19
eroman
6 years, 7 months ago (2014-05-23 19:12:05 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 manually as r272577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698