Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7431)

Unified Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_prompt_android.cc
diff --git a/chrome/browser/permissions/permission_prompt_android.cc b/chrome/browser/permissions/permission_prompt_android.cc
index ae7ff54a0f6487f648c60965798c4722d747b13a..1910bb0370bf7fb08780173e7c4e3a6319a3f67a 100644
--- a/chrome/browser/permissions/permission_prompt_android.cc
+++ b/chrome/browser/permissions/permission_prompt_android.cc
@@ -32,7 +32,8 @@ void PermissionPromptAndroid::Show() {
requests_[0]->GetOrigin());
}
-bool PermissionPromptAndroid::CanAcceptRequestUpdate() {
+bool PermissionPromptAndroid::MaybeCancelRequest() {
+ // We do not support cancelling on Android to keep the code simple.
return false;
}
@@ -41,8 +42,7 @@ bool PermissionPromptAndroid::HidesAutomatically() {
}
void PermissionPromptAndroid::Hide() {
- // Hide() is only called if HidesAutomatically() returns false or
- // CanAcceptRequestUpdate() return true.
+ // Hide() is not called because HidesAutomatically() returns true
NOTREACHED();
}
« no previous file with comments | « chrome/browser/permissions/permission_prompt_android.h ('k') | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698