Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_prompt_android.h" 5 #include "chrome/browser/permissions/permission_prompt_android.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/infobars/infobar_service.h" 8 #include "chrome/browser/infobars/infobar_service.h"
9 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android .h" 9 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android .h"
10 #include "chrome/browser/permissions/permission_request.h" 10 #include "chrome/browser/permissions/permission_request.h"
(...skipping 14 matching lines...) Expand all
25 InfoBarService* infobar_service = 25 InfoBarService* infobar_service =
26 InfoBarService::FromWebContents(web_contents_); 26 InfoBarService::FromWebContents(web_contents_);
27 if (!infobar_service) 27 if (!infobar_service)
28 return; 28 return;
29 29
30 requests_ = delegate_->Requests(); 30 requests_ = delegate_->Requests();
31 GroupedPermissionInfoBarDelegate::Create(this, infobar_service, 31 GroupedPermissionInfoBarDelegate::Create(this, infobar_service,
32 requests_[0]->GetOrigin()); 32 requests_[0]->GetOrigin());
33 } 33 }
34 34
35 bool PermissionPromptAndroid::CanAcceptRequestUpdate() { 35 bool PermissionPromptAndroid::MaybeCancelRequest() {
36 // We do not support cancelling on Android to keep the code simple.
36 return false; 37 return false;
37 } 38 }
38 39
39 bool PermissionPromptAndroid::HidesAutomatically() { 40 bool PermissionPromptAndroid::HidesAutomatically() {
40 return true; 41 return true;
41 } 42 }
42 43
43 void PermissionPromptAndroid::Hide() { 44 void PermissionPromptAndroid::Hide() {
44 // Hide() is only called if HidesAutomatically() returns false or 45 // Hide() is not called because HidesAutomatically() returns true
45 // CanAcceptRequestUpdate() return true.
46 NOTREACHED(); 46 NOTREACHED();
47 } 47 }
48 48
49 void PermissionPromptAndroid::UpdateAnchorPosition() { 49 void PermissionPromptAndroid::UpdateAnchorPosition() {
50 NOTREACHED() << "UpdateAnchorPosition is not implemented"; 50 NOTREACHED() << "UpdateAnchorPosition is not implemented";
51 } 51 }
52 52
53 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() { 53 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() {
54 NOTREACHED() << "GetNativeWindow is not implemented"; 54 NOTREACHED() << "GetNativeWindow is not implemented";
55 return nullptr; 55 return nullptr;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 size_t position) const { 93 size_t position) const {
94 DCHECK_LT(position, requests_.size()); 94 DCHECK_LT(position, requests_.size());
95 return requests_[position]->GetMessageTextFragment(); 95 return requests_[position]->GetMessageTextFragment();
96 } 96 }
97 97
98 // static 98 // static
99 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create( 99 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(
100 content::WebContents* web_contents) { 100 content::WebContents* web_contents) {
101 return base::MakeUnique<PermissionPromptAndroid>(web_contents); 101 return base::MakeUnique<PermissionPromptAndroid>(web_contents);
102 } 102 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_prompt_android.h ('k') | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698