Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2829003004: Merge M59: Media Remoting: Remove old interstitial implementation. (Closed)

Created:
3 years, 8 months ago by xjz
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge M59: Media Remoting: Remove old interstitial implementation. Remove old implementation that renders the interstitial on a video frame. The new implemenation is committed: https://codereview.chromium.org/2767823002/ BUG=713253 NOTRY=true NOPRESUBMIT=true TBR=miu@chromium.org,sandersd@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2801853002 Cr-Commit-Position: refs/heads/master@{#465303} (cherry picked from commit 2504c4da27a272a4906a7fd1bde697c8bdf7def1) Review-Url: https://codereview.chromium.org/2829003004 Cr-Commit-Position: refs/branch-heads/3071@{#97} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2828b8c2d6fd95fccb8145129deb99c33790ec80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -485 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/media/media_resource_provider.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M media/base/localized_strings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/media_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/remoting/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M media/remoting/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M media/remoting/courier_renderer.h View 5 chunks +0 lines, -23 lines 0 comments Download
M media/remoting/courier_renderer.cc View 3 chunks +3 lines, -44 lines 0 comments Download
D media/remoting/interstitial.h View 1 chunk +0 lines, -45 lines 0 comments Download
D media/remoting/interstitial.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M media/remoting/renderer_controller.h View 4 chunks +0 lines, -58 lines 0 comments Download
M media/remoting/renderer_controller.cc View 6 chunks +3 lines, -109 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829003004/1
3 years, 8 months ago (2017-04-20 20:00:22 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:01:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2828b8c2d6fd95fccb8145129deb...

Powered by Google App Engine
This is Rietveld 408576698