Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2828933003: Convert constructor/channelmerger.html to use new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert constructor/channelmerger.html to use new Audit Manually converted to use new Audit. Also fixed small typo in new-audionodeoptions.js. The dictionary members ChannelCount and ChannelCountMode should start with a lower-case letter "c". BUG=704967 TEST=constructor/channelmerger.html Review-Url: https://codereview.chromium.org/2828933003 Cr-Commit-Position: refs/heads/master@{#466646} Committed: https://chromium.googlesource.com/chromium/src/+/bbc815e58a697d89cc1473a576ad8572cb3a2043

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -126 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html View 1 2 1 chunk +69 lines, -114 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/new-audionodeoptions.js View 1 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-21 21:06:48 UTC) #3
hongchan
This one looks clean except for "var". lgtm with nits https://codereview.chromium.org/2828933003/diff/20001/third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html File third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html (right): https://codereview.chromium.org/2828933003/diff/20001/third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html#newcode14 ...
3 years, 8 months ago (2017-04-21 21:40:24 UTC) #4
Raymond Toy
https://codereview.chromium.org/2828933003/diff/20001/third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html File third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html (right): https://codereview.chromium.org/2828933003/diff/20001/third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html#newcode14 third_party/WebKit/LayoutTests/webaudio/constructor/channelmerger.html:14: var context; On 2017/04/21 21:40:24, hongchan wrote: > var ...
3 years, 8 months ago (2017-04-21 21:49:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828933003/40001
3 years, 8 months ago (2017-04-24 14:53:55 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 16:25:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bbc815e58a697d89cc1473a576ad...

Powered by Google App Engine
This is Rietveld 408576698