[console] fast console.assert(true)

src/inspector/v8-console.cc

Index: src/inspector/v8-console.cc
diff --git a/src/inspector/v8-console.cc b/src/inspector/v8-console.cc
index 8af6dc7c20f6ee0dbd79183b808366bb7556f3df..2d516e849d25994fbd3c02b268552fd994ab9152 100644
--- a/src/inspector/v8-console.cc
+++ b/src/inspector/v8-console.cc
@@ -89,12 +89,6 @@ class ConsoleHelper {
     reportCall(ConsoleAPIType::kWarning, arguments);
   }
 
-  bool firstArgToBoolean(bool defaultValue) {
-    if (m_info.Length() < 1) return defaultValue;
-    if (m_info[0]->IsBoolean()) return m_info[0].As<v8::Boolean>()->Value();
-    return m_info[0]->BooleanValue(m_context).FromMaybe(defaultValue);
-  }
-
   String16 firstArgToString(const String16& defaultValue) {
     if (m_info.Length() < 1) return defaultValue;
     v8::Local<v8::String> titleValue;
@@ -279,7 +273,6 @@ void V8Console::Count(const v8::debug::ConsoleCallArguments& info) {
 
 void V8Console::Assert(const v8::debug::ConsoleCallArguments& info) {

[Igor Sheludko, 2017/04/20 10:18:42]

Maybe ReportAssertionFailure or something similar will be a better name for this
builtin.

[Igor Sheludko, 2017/04/20 14:26:10]

Given that we are passing all the arguments (including the "check" value) the
Assert name is fine. Please ignore the above comment.

[kozy, 2017/04/20 15:14:54]

It would be cool to pass all arguments except first one but as far as I
understand to avoid any kind of hacks and introducing new CallDescriptor for
specific ConsoleAssert it's not possible without popping all arguments and then
pushing back all of them except first one.

   ConsoleHelper helper(info, m_inspector);

[Igor Sheludko, 2017/04/20 10:18:42]

or DCHECK(!helper.firstArgToBoolean(false));

[kozy, 2017/04/20 15:14:54]

added DCHECK.

-  if (helper.firstArgToBoolean(false)) return;
 
   std::vector<v8::Local<v8::Value>> arguments;
   for (int i = 1; i < info.Length(); ++i) arguments.push_back(info[i]);