[console] fast console.assert(true)

src/inspector/v8-console.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-console.h"
 
 #include "src/base/macros.h"
 #include "src/inspector/injected-script.h"
 #include "src/inspector/inspected-context.h"
 #include "src/inspector/string-util.h"
@@ skipping 71 matching lines @@
   void reportDeprecatedCall(const char* id, const String16& message) {
     if (!consoleMessageStorage()->shouldReportDeprecationMessage(m_contextId,
                                                                  id)) {
       return;
     }
     std::vector<v8::Local<v8::Value>> arguments(1,
                                                 toV8String(m_isolate, message));
     reportCall(ConsoleAPIType::kWarning, arguments);
   }
 
-  bool firstArgToBoolean(bool defaultValue) {
-    if (m_info.Length() < 1) return defaultValue;
-    if (m_info[0]->IsBoolean()) return m_info[0].As<v8::Boolean>()->Value();
-    return m_info[0]->BooleanValue(m_context).FromMaybe(defaultValue);
-  }
-
   String16 firstArgToString(const String16& defaultValue) {
     if (m_info.Length() < 1) return defaultValue;
     v8::Local<v8::String> titleValue;
     if (m_info[0]->IsObject()) {
       if (!m_info[0].As<v8::Object>()->ObjectProtoToString(m_context).ToLocal(
               &titleValue))
         return defaultValue;
     } else {
       if (!m_info[0]->ToString(m_context).ToLocal(&titleValue))
         return defaultValue;
@@ skipping 162 matching lines @@
   }
 
   int count =
       helper.consoleMessageStorage()->count(helper.contextId(), identifier);
   String16 countString = String16::fromInteger(count);
   helper.reportCallWithArgument(
       ConsoleAPIType::kCount,
       title.isEmpty() ? countString : (title + ": " + countString));
 }
 
 void V8Console::Assert(const v8::debug::ConsoleCallArguments& info) {

[Igor Sheludko, 2017/04/20 10:18:42]

Maybe ReportAssertionFailure or something similar will be a better name for this
builtin.

[Igor Sheludko, 2017/04/20 14:26:10]

Given that we are passing all the arguments (including the "check" value) the
Assert name is fine. Please ignore the above comment.

[kozy, 2017/04/20 15:14:54]

It would be cool to pass all arguments except first one but as far as I
understand to avoid any kind of hacks and introducing new CallDescriptor for
specific ConsoleAssert it's not possible without popping all arguments and then
pushing back all of them except first one.

   ConsoleHelper helper(info, m_inspector);

[Igor Sheludko, 2017/04/20 10:18:42]

or DCHECK(!helper.firstArgToBoolean(false));

[kozy, 2017/04/20 15:14:54]

added DCHECK.

-  if (helper.firstArgToBoolean(false)) return;
 
   std::vector<v8::Local<v8::Value>> arguments;
   for (int i = 1; i < info.Length(); ++i) arguments.push_back(info[i]);
   if (info.Length() < 2)
     arguments.push_back(
         toV8String(m_inspector->isolate(), String16("console.assert")));
   helper.reportCall(ConsoleAPIType::kAssert, arguments);
 
   if (V8DebuggerAgentImpl* debuggerAgent = helper.debuggerAgent())
     debuggerAgent->breakProgramOnException(
@@ skipping 458 matching lines @@
                          ->GetOwnPropertyDescriptor(
                              m_context, v8::Local<v8::String>::Cast(name))
                          .ToLocal(&descriptor);
       DCHECK(success);
       USE(success);
     }
   }
 }
 
 }  // namespace v8_inspector