Fix content quad size and translation

Fix content quad size and translation

BUG=713767
Review-Url: https://codereview.chromium.org/2828873005
Cr-Commit-Position: refs/heads/master@{#466072}
Committed: https://chromium.googlesource.com/chromium/src/+/f434f068dd1368d5b762aaba0798362922c6ab2e

[amp, 2017-04-20 17:20:27]

amp@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2017-04-20 17:21:37]

lgtm

https://codereview.chromium.org/2828873005/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2828873005/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager.cc:71: element->size = {2.4f,
1.6f, 1};
nit: Make constants, or otherwise show your work for generating these numbers

[amp, 2017-04-20 17:28:02]

The CQ bit was checked by amp@chromium.org

[amp, 2017-04-20 17:28:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2828873005/#ps20001
(title: "Fix content quad size and translation")

[amp, 2017-04-20 17:28:15]

The CQ bit was unchecked by amp@chromium.org

[amp, 2017-04-20 17:29:35]

On 2017/04/20 17:21:37, mthiesse wrote:
> lgtm
> 
>
https://codereview.chromium.org/2828873005/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):
> 
>
https://codereview.chromium.org/2828873005/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/ui_scene_manager.cc:71: element->size = {2.4f,
> 1.6f, 1};
> nit: Make constants, or otherwise show your work for generating these numbers

I agree, although this file was quick and dirty (the warnings have hardcoded
values as well).

The numbers just come directly from spec (I'm not sure how Josh generated them).

I think we should update the whole file in a future change (that won't be merged
back to 59).

[amp, 2017-04-20 17:30:04]

The CQ bit was checked by amp@chromium.org

[commit-bot: I haz the power, 2017-04-20 17:30:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 18:12:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492709404369580,
"parent_rev": "1bc3466095f183745f2fc934b266869689fba7d5", "commit_rev":
"f434f068dd1368d5b762aaba0798362922c6ab2e"}

[commit-bot: I haz the power, 2017-04-20 18:12:42]

Description was changed from

==========
Fix content quad size and translation

BUG=713767
==========

to

==========
Fix content quad size and translation

BUG=713767

Review-Url: https://codereview.chromium.org/2828873005
Cr-Commit-Position: refs/heads/master@{#466072}
Committed:
https://chromium.googlesource.com/chromium/src/+/f434f068dd1368d5b762aaba0798...
==========

[commit-bot: I haz the power, 2017-04-20 18:12:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f434f068dd1368d5b762aaba0798...