Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2828873003: Fixing display issue in bookmark manager. (Closed)

Created:
3 years, 8 months ago by Paezagon
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing display issue in bookmark manager. Splitting bookmark strings into two sets, the original strings and the new strings, because the original strings are still needed for the bookmark manager until how to get the pluralization to work is figured out. BUG=708815, 712995 Review-Url: https://codereview.chromium.org/2828873003 Cr-Commit-Position: refs/heads/master@{#466038} Committed: https://chromium.googlesource.com/chromium/src/+/c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing grammer mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -56 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 2 chunks +54 lines, -36 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Paezagon
Hello, Small patch fixing visual bug related to Issue 708815. Thanks, Anna
3 years, 8 months ago (2017-04-19 22:19:03 UTC) #2
Peter Kasting
This is a temporary hack, right? LGTM https://codereview.chromium.org/2828873003/diff/1/chrome/app/bookmarks_strings.grdp File chrome/app/bookmarks_strings.grdp (right): https://codereview.chromium.org/2828873003/diff/1/chrome/app/bookmarks_strings.grdp#newcode67 chrome/app/bookmarks_strings.grdp:67: &Open all ...
3 years, 8 months ago (2017-04-20 00:01:59 UTC) #3
Paezagon
Yes, this is a temporary hack. https://codereview.chromium.org/2828873003/diff/1/chrome/app/bookmarks_strings.grdp File chrome/app/bookmarks_strings.grdp (right): https://codereview.chromium.org/2828873003/diff/1/chrome/app/bookmarks_strings.grdp#newcode67 chrome/app/bookmarks_strings.grdp:67: &Open all bookmark ...
3 years, 8 months ago (2017-04-20 15:56:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828873003/20001
3 years, 8 months ago (2017-04-20 16:45:51 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:16:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c32cfc7c2ca9fbc0c289dba04d78...

Powered by Google App Engine
This is Rietveld 408576698