[DevTools] enable async stacks by default

[DevTools] enable async stacks by default

- increased async stack trace depth limit to 32 (currently we can do any number here without increasing running time or memory consumption but then we need better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and without async stacks is almost unobservable,
- promises are only twice slower.

More numbers: https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164, v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2828863002
Cr-Commit-Position: refs/heads/master@{#466749}
Committed: https://chromium.googlesource.com/chromium/src/+/4112b4cc46cbc283a72d79087acb83f24fb4af58

[kozy, 2017-04-19 18:59:58]

Description was changed from

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (we can do any number here but
then we need better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

to

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (we can do any number here but
then we need better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

[kozy, 2017-04-19 19:00:10]

Description was changed from

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (we can do any number here but
then we need better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

to

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (currently we can do any number
here but then we need better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

[kozy, 2017-04-19 19:00:41]

Description was changed from

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (currently we can do any number
here but then we need better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

to

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

[kozy, 2017-04-19 19:01:19]

Description was changed from

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
==========

to

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
R=dgozman@chromium.org
==========

[kozy, 2017-04-19 19:01:19]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2017-04-19 19:03:03]

Dmitry please take a look :)

[kozy, 2017-04-20 20:16:27]

Everything on V8 side landed, please take a look :)

[dgozman, 2017-04-21 23:11:15]

Description was changed from

==========
[DevTools] enable async stacks by default..

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
R=dgozman@chromium.org
==========

to

==========
[DevTools] enable async stacks by default

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
R=dgozman@chromium.org
==========

[dgozman, 2017-04-21 23:39:17]

Looks very good!

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt
(right):

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt:11:
setTimeout (async)
Did you manually check all the test expectations changes?

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-pause-on-exception-expected.txt
(right):

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-pause-on-exception-expected.txt:10:
0) scheduleTestFunction (debugger-test.js:3)
Why suddenly this?

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:179:
asyncStackTracesStateChanged() {
While we are here, let's make this private.

[kozy, 2017-04-22 00:02:57]

all done, thanks.

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt
(right):

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-error-on-call-frame-expected.txt:11:
setTimeout (async)
On 2017/04/21 23:39:17, dgozman wrote:
> Did you manually check all the test expectations changes?

I run all tests in chrome with CL and tried to run code in the same way as test
do, all reasults looks good to me and I took a look on
http/tests/inspector/service-workers/lazy-addeventlisteners-expected.txt, it
looks good too.

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-pause-on-exception-expected.txt
(right):

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-pause-on-exception-expected.txt:10:
0) scheduleTestFunction (debugger-test.js:3)
On 2017/04/21 23:39:17, dgozman wrote:
> Why suddenly this?

We skip all frames after frame with functionName === 'scheduleTestFunction'
including this frame [1] 

[1]
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test...

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/2828863002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:179:
asyncStackTracesStateChanged() {
On 2017/04/21 23:39:17, dgozman wrote:
> While we are here, let's make this private.

Done.

[kozy, 2017-04-22 00:04:07]

> We skip all frames after frame with functionName === 'scheduleTestFunction'
> including this frame [1] 

I mean " and including this frame into test results."

[kozy, 2017-04-22 00:04:13]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 00:04:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 02:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 02:03:21]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-24 18:51:09]

lgtm

[kozy, 2017-04-24 18:51:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:52:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 20:40:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493059886651690,
"parent_rev": "40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418", "commit_rev":
"4112b4cc46cbc283a72d79087acb83f24fb4af58"}

[commit-bot: I haz the power, 2017-04-24 20:40:55]

Description was changed from

==========
[DevTools] enable async stacks by default

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
R=dgozman@chromium.org
==========

to

==========
[DevTools] enable async stacks by default

- increased async stack trace depth limit to 32 (currently we can do any number
here without increasing running time or memory consumption but then we need
better UX for stack traces),
- added disable async stack traces settings to the settings list under Debugger
category,
- changed limit for tests and rebased all tests with new async stacks.

Summary of backend improvements:
- async stacks has predictible peak memory usage - ~20 Mbytes,
- change of running time of setTimeout, setInterval, requestAnimation with and
without async stacks is almost unobservable,
- promises are only twice slower.

More numbers:
https://docs.google.com/document/d/13H1Pn6dekcwqlaYP26CfyyYGuL-U9LtUPWmt3TIpOag

BUG=chromium:693164,v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2828863002
Cr-Commit-Position: refs/heads/master@{#466749}
Committed:
https://chromium.googlesource.com/chromium/src/+/4112b4cc46cbc283a72d79087acb...
==========

[commit-bot: I haz the power, 2017-04-24 20:40:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4112b4cc46cbc283a72d79087acb...