Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2828853002: Chrome OS: adjust wifi icons. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Chrome OS: adjust wifi icons. 1. In the system tray, if wifi is disabled, the icon is a white wedge with strikethrough. If wifi is enabled and no network is connected, the icon is an empty wedge without a strikethrough. 2. In the default view (system bubble row) the icon is either a normal, badged icon if connected, an empty wedge if enabled but disconnected, or a full strength wedge with strikethough but with 0.54a if disabled. 3. In the notification, the icon is full strength with or without strikethough, depending on enabled state. BUG=711555 Review-Url: https://codereview.chromium.org/2817223003 Cr-Commit-Position: refs/heads/master@{#464999} (cherry picked from commit 7735ed2d044b9afaa1c853f003084a55e6c6e42a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -26 lines) Patch
M ash/system/network/network_icon.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/system/network/network_icon.cc View 3 chunks +25 lines, -16 lines 0 comments Download
M ash/system/network/tray_network.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M ash/system/tray/tray_popup_item_style.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/system/tray/tray_popup_item_style.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698