Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2828833002: color: Fix custom params IPC (Closed)

Created:
3 years, 8 months ago by ccameron
Modified:
3 years, 8 months ago
Reviewers:
palmer
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Fix custom params IPC AddBytes and AddData need to be used consistently. BUG=711107 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2828833002 Cr-Commit-Position: refs/heads/master@{#466130} Committed: https://chromium.googlesource.com/chromium/src/+/0cf6c5aec94b518ae3d0850466e28bbae0f284b4

Patch Set 1 #

Patch Set 2 : color: Fix custom params IPC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M cc/ipc/struct_traits_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
ccameron
ptal -- small fix (very surprised that this ever worked!)
3 years, 8 months ago (2017-04-19 18:16:51 UTC) #2
ccameron
ping
3 years, 8 months ago (2017-04-20 16:48:16 UTC) #7
palmer
Maybe file a bug for it, and add a test, to make sure this works ...
3 years, 8 months ago (2017-04-20 17:40:08 UTC) #8
ccameron
Added a test, and rolled it into the feature where I found the issue.
3 years, 8 months ago (2017-04-20 19:40:34 UTC) #13
palmer
lgtm
3 years, 8 months ago (2017-04-20 19:49:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828833002/20001
3 years, 8 months ago (2017-04-20 19:50:39 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 21:07:44 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0cf6c5aec94b518ae3d0850466e2...

Powered by Google App Engine
This is Rietveld 408576698