XHR: Lowercase header names returned by getAllResponseHeaders().

XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/issues/109 and its related
https://github.com/whatwg/xhr/commit/ecce3904ace, which aligned some of
XHR's behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

Intent to implement thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_oxlCPNsrck/2FePT4QaBwAJ
    
BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2828753002
Cr-Commit-Position: refs/heads/master@{#473567}
Committed: https://chromium.googlesource.com/chromium/src/+/99c274ae8e7d366261dcfb89e0b98e733fb9d5f4

[Raphael Kubo da Costa (rakuco), 2017-04-19 15:46:38]

PTAL

[Raphael Kubo da Costa (rakuco), 2017-04-19 15:46:45]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 15:47:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 17:39:53]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-04-20 04:49:00]

I'm not sure if intent-to-(ship? change?) is needed for this change. I sent a
email to blink-dev.

[tyoshino (SeeGerritForStatus), 2017-04-20 05:47:39]

Regarding the spec side changes to cite,

https://github.com/whatwg/xhr/commit/ecce3904ace0dbe382a652ea1d8e29c7885fe8c4
was the change that let XHR switch to use sort and combine.

https://github.com/w3c/web-platform-tests/pull/4641 was introduced to test
https://github.com/whatwg/xhr/pull/130 but it looks it became the first to test
case of getAllResponseHeaders() accidentally.

https://github.com/whatwg/xhr/issues/109 might be the best PR to cite regarding
casing.

[tyoshino (SeeGerritForStatus), 2017-04-20 05:48:33]

On 2017/04/20 05:47:39, tyoshino wrote:
> Regarding the spec side changes to cite,
> 
> https://github.com/whatwg/xhr/commit/ecce3904ace0dbe382a652ea1d8e29c7885fe8c4
> was the change that let XHR switch to use sort and combine.
> 
> https://github.com/w3c/web-platform-tests/pull/4641 was introduced to test
> https://github.com/whatwg/xhr/pull/130 but it looks it became the first to
test
> case of getAllResponseHeaders() accidentally.
> 
> https://github.com/whatwg/xhr/issues/109 might be the best PR to cite
regarding
> casing.

and youennf's comment here
https://github.com/whatwg/fetch/pull/476#discussion_r100350231

[tyoshino (SeeGerritForStatus), 2017-04-20 09:18:00]

Change looks good. Please wait for conclusion at the thread yhirano@ created.

[Raphael Kubo da Costa (rakuco), 2017-04-20 14:19:36]

Description was changed from

==========
XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/pull/130, which aligned some of XHR's
behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org
==========

to

==========
XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/issues/109 and its related
https://github.com/whatwg/xhr/commit/ecce3904ace, which aligned some of
XHR's behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org
==========

[Raphael Kubo da Costa (rakuco), 2017-04-20 15:10:18]

Thanks, guys. Since yhirano's thread seems to indicate people would prefer an
intent email to be sent, I did that here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/cakEmcqoWoA

[Raphael Kubo da Costa (rakuco), 2017-05-22 11:17:15]

Description was changed from

==========
XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/issues/109 and its related
https://github.com/whatwg/xhr/commit/ecce3904ace, which aligned some of
XHR's behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org
==========

to

==========
XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/issues/109 and its related
https://github.com/whatwg/xhr/commit/ecce3904ace, which aligned some of
XHR's behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

Intent to implement thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_oxlCPNsrck/2FePT4Qa...
    
BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org
==========

[Raphael Kubo da Costa (rakuco), 2017-05-22 11:17:43]

Today I got the third required LGTM for this change, and I've now rebased the
patch.

Please take a look.

[Raphael Kubo da Costa (rakuco), 2017-05-22 11:17:47]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 11:17:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 12:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 12:49:14]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-05-22 12:55:11]

lgtm

[Raphael Kubo da Costa (rakuco), 2017-05-22 13:23:29]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-05-22 13:23:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 13:28:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495459409861580,
"parent_rev": "50bbde70a79349d7c71655cb1042fa559fc4a568", "commit_rev":
"99c274ae8e7d366261dcfb89e0b98e733fb9d5f4"}

[commit-bot: I haz the power, 2017-05-22 13:28:38]

Description was changed from

==========
XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/issues/109 and its related
https://github.com/whatwg/xhr/commit/ecce3904ace, which aligned some of
XHR's behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

Intent to implement thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_oxlCPNsrck/2FePT4Qa...
    
BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org
==========

to

==========
XHR: Lowercase header names returned by getAllResponseHeaders().

Adapt to https://github.com/whatwg/xhr/issues/109 and its related
https://github.com/whatwg/xhr/commit/ecce3904ace, which aligned some of
XHR's behavior with Fetch's.

Specifically in this case, getAllResponseHeaders() is supposed to execute
Fetch's "sort and combine" steps, which include lowercasing all header
names.

Note that this commit does not fully implement the "sort" bit: that one is
currently done only in the Fetch code, and we should instead move that part
of the code to core/ or platform/loader/ instead.

Intent to implement thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_oxlCPNsrck/2FePT4Qa...
    
BUG=700434
R=mkwst@chromium.org,tyoshino@chromium.org,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2828753002
Cr-Commit-Position: refs/heads/master@{#473567}
Committed:
https://chromium.googlesource.com/chromium/src/+/99c274ae8e7d366261dcfb89e0b9...
==========

[commit-bot: I haz the power, 2017-05-22 13:28:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99c274ae8e7d366261dcfb89e0b9...