Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2828693006: Use unique_ptrs in PrintPreviewDataService. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique_ptrs in PrintPreviewDataService. Putting unique_ptrs in STL containers was not possible when the class was first written. Review-Url: https://codereview.chromium.org/2828693006 Cr-Commit-Position: refs/heads/master@{#466252} Committed: https://chromium.googlesource.com/chromium/src/+/23d995ef161f8ed3b4bd84a436655f9e104667f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M chrome/browser/printing/print_preview_data_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_data_service.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 8 months ago (2017-04-20 18:41:07 UTC) #6
rbpotter
On 2017/04/20 18:41:07, Lei Zhang wrote: lgtm
3 years, 8 months ago (2017-04-21 00:45:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828693006/1
3 years, 8 months ago (2017-04-21 04:00:10 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 04:05:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23d995ef161f8ed3b4bd84a43665...

Powered by Google App Engine
This is Rietveld 408576698