Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2828693002: [blink] Request compositing update when canvas hibernates/wakes up. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[blink] Request compositing update when canvas hibernates/wakes up. Not requesting the update can lead to the canvas not being shown, as in the bug referenced below. BUG=708445 Review-Url: https://codereview.chromium.org/2808493002 Cr-Commit-Position: refs/heads/master@{#465206} (cherry picked from commit 5047940999a9cf13e8635e61112fdaa7db885726) Review-Url: https://codereview.chromium.org/2828693002 . Cr-Commit-Position: refs/branch-heads/3071@{#47} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0009f9a6c1416b2a23a33f69a86f5d21dccbf620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 5 chunks +76 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eric Seckler
3 years, 8 months ago (2017-04-19 12:41:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0009f9a6c1416b2a23a33f69a86f5d21dccbf620.

Powered by Google App Engine
This is Rietveld 408576698