Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2828663002: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/{i,l,m,n,p,r}* (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, ntp-dev+reviews_chromium.org, Peter Beverloo, tfarina, johnme+watch_chromium.org, jam, Randy Smith (Not in Mondays), loading-reviews+metrics_chromium.org, csharrison+watch_chromium.org, noyau+watch_chromium.org, raymes+watch_chromium.org, speed-metrics-reviews_chromium.org, loading-reviews_chromium.org, native-client-reviews_googlegroups.com, harkness+watch_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/{i,l,m,n,p,r}* This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 Review-Url: https://codereview.chromium.org/2828663002 Cr-Commit-Position: refs/heads/master@{#466030} Committed: https://chromium.googlesource.com/chromium/src/+/3f7781da5e43f9c32b5e4654e08b6d5386597fc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -274 lines) Patch
M chrome/browser/icon_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/icon_loader_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/image_decoder.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_responder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/interstitials/chrome_controller_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/io_thread.cc View 4 chunks +24 lines, -30 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 6 chunks +26 lines, -24 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/loader/safe_browsing_resource_throttle.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mdns.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/manifest/manifest_icon_downloader.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net_benchmarking.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/experiments/delay_navigation_throttle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 16 chunks +33 lines, -37 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/permissions/permission_blacklist_client.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/platform_util.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_posix.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_browsertest.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_notification_manager.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tzik
PTAL
3 years, 8 months ago (2017-04-20 06:28:19 UTC) #6
Nico
lgtm
3 years, 8 months ago (2017-04-20 15:29:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828663002/1
3 years, 8 months ago (2017-04-20 15:29:49 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:09:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f7781da5e43f9c32b5e4654e08b...

Powered by Google App Engine
This is Rietveld 408576698