third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h - Issue 2828643002: Make customElements.define faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

Issue 2828643002: Make customElements.define faster

Patch Set: Try to make Android builder happy. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

index 5ba1190e4d2f4a60393f76978816fc84d20681f7..9fe6d1c73e7ab20e544856d9adc2cfec5e7c8e8a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

@@ -41,7 +41,8 @@ class CORE_EXPORT ScriptCustomElementDefinitionBuilder

bool CheckConstructorNotRegistered() override;

bool CheckPrototype() override;

bool RememberOriginalProperties() override;

- CustomElementDefinition* Build(const CustomElementDescriptor&) override;

+ CustomElementDefinition* Build(const CustomElementDescriptor&,

+ CustomElementDefinition::Id) override;

private:

static ScriptCustomElementDefinitionBuilder* stack_;